OS::Heat::SoftwareDeploymentGroup provides a min_in_service field in rolling_update policy

Bug #1624387 reported by Zane Bitter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Zane Bitter

Bug Description

The change to add rolling_update and batch_create policies to OS::Heat::SoftwareDeploymentGroup (https://review.openstack.org/#/c/330467/) defines a new schema for the rolling_update policy that excludes the min_in_service field (which makes no sense for a SoftwareDeploymentGroup). However, it doesn't actually use the schema it has defined, but instead inherits the one defined by ResourceGroup, which includes min_in_service.

Since the feature was introduced in Newton, it would be nice to release with the correct schema so we don't have to think about a deprecation process or anything.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/371536

Zane Bitter (zaneb)
tags: added: newton-rc-potential
Changed in heat:
importance: High → Medium
Revision history for this message
Rabi Mishra (rabi) wrote :

Yeah it's using incorrect schema. Though it's actually ignoring min_in_service for rolling_update.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/371536
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=676281dc8c6708edf7e0b5a6c0a508f0b031d497
Submitter: Jenkins
Branch: master

commit 676281dc8c6708edf7e0b5a6c0a508f0b031d497
Author: Zane Bitter <email address hidden>
Date: Fri Sep 16 09:22:01 2016 -0400

    Use correct schema for SoftwareDeploymentGroup rolling_update

    Change-Id: Ie5f1df4862fcbe7fc2949b3516f91e193461b2a0
    Closes-Bug: #1624387

Changed in heat:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/372697

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/newton)

Reviewed: https://review.openstack.org/372697
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=14a90d67a6444db8c519b4d0b9a3eadebe08287c
Submitter: Jenkins
Branch: stable/newton

commit 14a90d67a6444db8c519b4d0b9a3eadebe08287c
Author: Zane Bitter <email address hidden>
Date: Fri Sep 16 09:22:01 2016 -0400

    Use correct schema for SoftwareDeploymentGroup rolling_update

    Change-Id: Ie5f1df4862fcbe7fc2949b3516f91e193461b2a0
    Closes-Bug: #1624387
    (cherry picked from commit 676281dc8c6708edf7e0b5a6c0a508f0b031d497)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 7.0.0.0rc2

This issue was fixed in the openstack/heat 7.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 7.0.0

This issue was fixed in the openstack/heat 7.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 8.0.0.0b1

This issue was fixed in the openstack/heat 8.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.