ooi fails with 500 when deleting a volume

[Alvaro Lopez]

When deleting an volume ooi returns HTTP[500] (but the image in question is deleted):

    <- "DELETE /occi1.1/storage/86f9b574-859f-4b45-93b0-098d1540c9a6 HTTP/1.1\r\nAccept: text/plain,text/occi\r\nUser-Agent: rOCCI-core/4.3.2 rOCCI-api/4.3.5 OCCI/1.1 ruby-x86_64-linux/2.2.4p230\r\nX-Auth-Token: TOKEN_HERE\r\nConnection: close\r\nHost: cloud.ifca.es:8787\r\n\r\n"
    -> "HTTP/1.1 500 Internal Server Error\r\n"
    -> "Date: Thu, 15 Sep 2016 08:54:28 GMT\r\n"
    -> "Content-Type: text/plain; charset=UTF-8\r\n"
    -> "Content-Length: 82\r\n"
    -> "Connection: close\r\n"
    -> "server: ooi/0.1.1 OCCI/1.1\r\n"
    -> "x-compute-request-id: req-d2df378a-635f-42e0-9f5c-b90c2a8d41a6\r\n"
    -> "\r\n"
    reading 82 bytes...
    -> "The server has either erred or is incapable of performing the requested operation."
    read 82 bytes
    Conn close

ooi logs shows the following in the logs

 2016-09-15 10:54:28.681 11539 ERROR ooi.api.helpers [req-d2df378a-635f-42e0-9f5c-b90c2a8d41a6 7050a82701b04f8d8f61098a07ff0ebc 999f045cb1ff4684a15ebb338af69460 - - -] Unknown error happenened processing response 202 Accepted
 Content-Length: 0
 Content-Type: application/json
 X-OpenStack-Nova-API-Version: 2.1
 Vary: X-OpenStack-Nova-API-Version
 2016-09-15 10:54:28.681 11539 ERROR ooi.api.helpers Traceback (most recent call last):
 2016-09-15 10:54:28.681 11539 ERROR ooi.api.helpers File "/usr/lib/python2.7/dist-packages/ooi/api/helpers.py", line 91, in exception_from_response
 2016-09-15 10:54:28.681 11539 ERROR ooi.api.helpers message = response.json_body.popitem()[1].get("message")
 2016-09-15 10:54:28.681 11539 ERROR ooi.api.helpers File "/usr/lib/python2.7/dist-packages/webob/response.py", line 401, in _json_body__get
 2016-09-15 10:54:28.681 11539 ERROR ooi.api.helpers return json.loads(self.body.decode(self.charset or 'UTF-8'))
 2016-09-15 10:54:28.681 11539 ERROR ooi.api.helpers File "/usr/lib/python2.7/dist-packages/simplejson/__init__.py", line 516, in loads
 2016-09-15 10:54:28.681 11539 ERROR ooi.api.helpers return _default_decoder.decode(s)
 2016-09-15 10:54:28.681 11539 ERROR ooi.api.helpers File "/usr/lib/python2.7/dist-packages/simplejson/decoder.py", line 370, in decode
 2016-09-15 10:54:28.681 11539 ERROR ooi.api.helpers obj, end = self.raw_decode(s)
 2016-09-15 10:54:28.681 11539 ERROR ooi.api.helpers File "/usr/lib/python2.7/dist-packages/simplejson/decoder.py", line 400, in raw_decode
 2016-09-15 10:54:28.681 11539 ERROR ooi.api.helpers return self.scan_once(s, idx=_w(s, idx).end())
 2016-09-15 10:54:28.681 11539 ERROR ooi.api.helpers JSONDecodeError: Expecting value: line 1 column 1 (char 0)
 2016-09-15 10:54:28.681 11539 ERROR ooi.api.helpers
 2016-09-15 10:54:28.712 11539 INFO ooi.wsgi [req-d2df378a-635f-42e0-9f5c-b90c2a8d41a6 7050a82701b04f8d8f61098a07ff0ebc 999f045cb1ff4684a15ebb338af69460 - - -] HTTP exception thrown: The server has either erred or is incapable of performing the requested operation.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/371328

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/371328
Committed: https://git.openstack.org/cgit/openstack/ooi/commit/?id=c83d3efe8bdd0d917a3b63a02f9fe8259cf99faf
Submitter: Jenkins
Branch: master

commit c83d3efe8bdd0d917a3b63a02f9fe8259cf99faf
Author: Alvaro Lopez Garcia <email address hidden>
Date: Fri Sep 16 09:42:43 2016 +0200

    Check for the correct HTTP return code when deleting a volume

    We were checking for a 204, but it will return a 202, so the volume was
    deleted but we returned an error 500.

    Change-Id: Id6e7e7def231182ca2e00dca3426501557c5b87e
    Close-Bug: #1624232