[2.1] mDNS label contains disallowed characters
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
Critical
|
Mike Pontillo |
Bug Description
At home I have a device on my network with the name "Living room". This is escaped by Avahi to "Living\032room", but this is rejected by MAAS.
1. This name ought to be accepted by MAAS.
2. Properly invalid names should not cause a crash like this.
Traceback (most recent call last):
File "/usr/lib/
self.
File ".../provisioni
return target()
File ".../twisted/
task()
File ".../twisted/
task()
--- <exception caught here> ---
File ".../twisted/
result = inContext.theWork()
File ".../twisted/
inContext.
File ".../twisted/
return self.currentCon
File ".../twisted/
return func(*args,**kw)
File ".../provisioni
callInContext
return func(*args, **kwargs)
File ".../maasserver
call_
return func_outside_
File ".../maasserver
return func(*args, **kwargs)
File "/usr/lib/
return func(*args, **kwds)
File ".../maasserver
in recordMDNSEntri
region_
File ".../maasserver
report_
interface.
File ".../maasserver
update_mdns_entry
interface=self, ip=ip, hostname=hostname)
File ".../django/
return getattr(
File ".../django/
obj.
File ".../maasserver
self.
File ".../django/
raise ValidationError
django.
disallowed characters: 'Living\
Related branches
- Blake Rouse (community): Approve
-
Diff: 107 lines (+26/-13)5 files modifiedsrc/maasserver/migrations/builtin/maasserver/0076_interface_discovery_rescue_mode.py (+1/-1)
src/maasserver/migrations/builtin/maasserver/0083_device_discovery.py (+1/-1)
src/maasserver/models/discovery.py (+1/-1)
src/maasserver/models/mdns.py (+5/-10)
src/maasserver/models/tests/test_mdns.py (+18/-0)
Changed in maas: | |
milestone: | none → 2.1.0 |
importance: | High → Critical |
Changed in maas: | |
status: | Triaged → Fix Committed |
summary: |
- mDNS label contains disallowed characters + [2.1] mDNS label contains disallowed characters |
Changed in maas: | |
status: | Fix Committed → Fix Released |
Changed in maas: | |
assignee: | nobody → Mike Pontillo (mpontillo) |