Nova requires netaddr >= 0.7.12 which is not enough

[Thomas Goirand]

In this commit:
https://github.com/openstack/nova/commit/4647f418afb9ced223c089f9d49cd686eccae9e2

nova starts using the modified_eui64() function which isn't available in netaddr 0.7.12. It is available in version 0.7.18, which is what the upper-constraints.txt has. I haven't investigate (yet) when the new method was introduce in netaddr, though in all reasonableness, I'd strongly suggest pushing for an upgrade of global-requirements.txt to 0.7.18 (which is what we've been gating on for a long time).

At the packaging level, it doesn't seem to be a big problem, as 0.7.18 is what Xenial has.

The other solution would be to remove the call of modified_eui64() in Nova, but this looks a more risky option to me, so close from the release.

[Sylvain Bauza (sylvain-bauza)]

So, the problem is that we would need to bump the lower bound in global requirements and sync up the nova requirements but since we're very close to branching Newton stable, that's not possible to have that for Newton, rather Ocata.

Given the bug scope is around a single TestCase which is not impacting our users, I tend to think that's a critical situation. That said, given the effort, I'm investigating the possibility to fix the testcase so that we could backport the bugfix to the Newton branch.

[Dr. Jens Harbott (j-harbott)]

After looking at the code, I think the bug will affect users. If nova runs with the wrong netaddr, this command should fail:

$ nova list --ip6 fdeb:25f3:4805:0:f816:3eff:febb:e594
+--------------------------------------+-------+--------+------------+-------------+--------------------------------------------------------+
| ID | Name | Status | Task State | Power State | Networks |
+--------------------------------------+-------+--------+------------+-------------+--------------------------------------------------------+
| 898044eb-8261-4032-8327-084966092c63 | test1 | ACTIVE | - | Running | private=fdeb:25f3:4805:0:f816:3eff:febb:e594, 10.0.0.7 |
+--------------------------------------+-------+--------+------------+-------------+--------------------------------------------------------+

[Sylvain Bauza (sylvain-bauza)]

Oh snap, you're right, the issue is touching the ipv6 API we create. Raising the criticity, while I'm working on a bugfix.

[Sylvain Bauza (sylvain-bauza)]

So, the change is pretty self-limited, I'm testing locally the difference and then I'll provide a bugfix soon.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/370665

[Sean Dague (sdague)]

It looks like this was added in 0.7.13 (released in 2014), for what it is worth

[Sean Dague (sdague)]

This really isn't a critical bug. We know that requirements minimums are untested, and likely wrong. We should fix the reality when we can.

A minimum of 0.7.13 in newton, and just make ocata 0.7.18 which is the tested version.

[Matt Riedemann (mriedem)]

Requirements change: https://review.openstack.org/#/c/370833/

[Matt Riedemann (mriedem)]

Nova fix: https://review.openstack.org/#/c/370846/

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sylvain Bauza (<email address hidden>) on branch: master
Review: https://review.openstack.org/370665
Reason: Abandoning in favor of https://review.openstack.org/#/c/370833/ and https://review.openstack.org/#/c/370846/ for the nova side.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/370846
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=bad2497b70605b66ada28960d9ccd9796a0867ee
Submitter: Jenkins
Branch: master

commit bad2497b70605b66ada28960d9ccd9796a0867ee
Author: Sean Dague <email address hidden>
Date: Thu Sep 15 09:49:08 2016 -0400

    Update minimum requirement for netaddr

    Depends-On: Iffede36c4d9fb3b27d94c9497980504a70a435ba

    Change-Id: I75770f3ed4fbf9f48fde210ece90662091bc0c23
    Closes-Bug: #1623838

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 14.0.0.0rc1 release candidate.