Make update allowed allowed_address_pairs property

[Sergey Kraynev]

Neutron client allows to update property: allowed_address_pairs
http://developer.openstack.org/api-ref/networking/v2/?expanded=show-port-details-detail,update-port-detail

Right now it cause if I want to update this resource it's not possible to use mac address of the same port, because setting new property cause update replace.
This update supported from liberty, so we also need backport fix to mitaka and liberty.

Scenario:
 - create stack with follow template:

heat_template_version: 2015-04-30

parameters:

  network:
    type: string
    default: private

resources:

  port:
    type: OS::Neutron::Port
    properties:
      network: { get_param: network }

  vm:
    type: OS::Nova::Server
    properties:
      image: cirros-0.3.4-x86_64-uec
      flavor: m1.micro
      networks:
        - port: { get_resource: port }

- get port mac address via outputs or port-show command
- update template by adding follow properties:
.........
  port:
    type: OS::Neutron::Port
    properties:
      network: { get_param: network }
      allowed_address_pairs:
        - mac_address: port_mac_address
          ip_address: 192.168.0.0/16
.......

Expected result:
allowed_address_pairs will be applied to the same mac address as port has.

Current result:
new port with different mac address during Update replace be created and allowed_address_pairs will contains old mac address, mentioned early

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/370603

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/370604

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/370605

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/370994

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/370603
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=353e7319dbbff7f10e7cdf664f017a01e15b5168
Submitter: Jenkins
Branch: master

commit 353e7319dbbff7f10e7cdf664f017a01e15b5168
Author: Sergey Kraynev <email address hidden>
Date: Thu Sep 15 04:08:20 2016 -0400

    Allow update inplace for allowed_address_pairs

    This patch allows to do update inplace for allowed_address_pairs
    properties. Scenario mentioned in bug works correct now.

    Also add couple fixes to related test:
    - Add explicit translation name to string, otherwise it returns objects,
      that raise error during resolving Property name, which should be a
      string.
    - Add check, that update of any of mentioned properties does not cause replace.

    Change-Id: I913fd36012179f2fdd602f2cca06a89e3fa896f3
    Closes-Bug: #1623821

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sergey Kraynev (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/370605

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/370994
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=5443453fbbaab761a42023c556ee7ed4c55d60ba
Submitter: Jenkins
Branch: stable/newton

commit 5443453fbbaab761a42023c556ee7ed4c55d60ba
Author: Sergey Kraynev <email address hidden>
Date: Thu Sep 15 04:08:20 2016 -0400

    Allow update inplace for allowed_address_pairs

    This patch allows to do update inplace for allowed_address_pairs
    properties. Scenario mentioned in bug works correct now.

    Also add couple fixes to related test:
    - Add explicit translation name to string, otherwise it returns objects,
      that raise error during resolving Property name, which should be a
      string.
    - Add check, that update of any of mentioned properties does not cause replace.

    Change-Id: I913fd36012179f2fdd602f2cca06a89e3fa896f3
    Closes-Bug: #1623821
    (cherry picked from commit 353e7319dbbff7f10e7cdf664f017a01e15b5168)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 7.0.0.0rc2 release candidate.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/370605
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=35e87b154ddde08590fc93c3d50030ae9d235dd7
Submitter: Jenkins
Branch: stable/liberty

commit 35e87b154ddde08590fc93c3d50030ae9d235dd7
Author: Sergey Kraynev <email address hidden>
Date: Fri Sep 16 05:41:45 2016 -0400

    Allow update inplace for allowed_address_pairs

    This patch allows to do update inplace for allowed_address_pairs
    properties. Scenario mentioned in bug works correct now.

    Change-Id: I913fd36012179f2fdd602f2cca06a89e3fa896f3
    Closes-Bug: #1623821

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 5.0.3 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 7.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 8.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sergey Kraynev (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/370604
Reason: Ok. Thank you guys for the feedback, I will abandon it ;)