Trunk, SEGV during startup

[Andy Valencia]

During startup of a fresh build of Midori from trunk checkout, I get a segv as it paints
the first window. gdb shows it to be a dereference of error->message, where "error" is a
null pointer. This is at line 445 in midori/midori-view.c. I patched it, and can now
run Midori.

=== modified file 'midori/midori-view.c'
--- midori/midori-view.c 2016-02-28 00:07:54 +0000
+++ midori/midori-view.c 2016-09-15 01:05:36 +0000
@@ -445,8 +445,10 @@
         pixbuf = gtk_icon_info_load_icon (icon_info, &error);
         g_strfreev (icon_names);
         if (pixbuf == NULL) {
- g_warning ("Could not load pixbuf for icon '%s': %s\n", icon_name, error->message);
- g_clear_error (&error);
+ if (error) {
+ g_warning ("Could not load pixbuf for icon '%s': %s\n", icon_name, error->message);
+ g_clear_error (&error);
+ }

             /* view->icon cannot be set to NULL, so we simply leave it as-is */
             return;

[gue5t gue5t (gue5t)]

This looks good, but it'd be nice to have more info on what caused the crash. Can you figure out which icon name it was looking for? Do you have any icon themes installed?

[Andy Valencia (ajv-701-189-4171)]

Sure, happy to help. I patched the code to show the failed icon, which was (null) as you can see.
I've included all the complaints Midori put to stderr during startup:

Gtk-WARNING **: Error loading theme icon 'bookmark-new' for stock: Icon 'bookmark-new' not present in theme

(midori4:7993): Gtk-WARNING **: Error loading theme icon 'user-trash' for stock: Icon 'user-trash' not present in theme

(midori4:7993): Gtk-CRITICAL **: IA__gtk_icon_info_load_icon: assertion 'icon_info != NULL' failed

** (midori4:7993): WARNING **: Did not load pixbuf for icon '(null)'

(midori4:7993): Gtk-CRITICAL **: IA__gtk_icon_info_load_icon: assertion 'icon_info != NULL' failed

** (midori4:7993): WARNING **: Did not load pixbuf for icon '(null)'

[Andy Valencia (ajv-701-189-4171)]

And, indeed, all I have is a stock Jessie Debian system with checkout/build/install of the trunk.
Unless "make install" put it into /usr/local, it isn't there.