Fuel plugin v5.0.0 custom graphs not working

Bug #1623557 reported by Ilya Kutukov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Critical
Ilya Kutukov

Bug Description

After installation of plugin with following field in metadata:

graphs:
- graph_path: graphs/custom.yaml
  type: custom

Following stacktrace occur:

[pid: 27712|app: 0|req: 13697/30358] 10.109.15.2 () {40 vars in 573 bytes} [Wed Sep 14 14:06:43 2016] GET /api/v1/plugins/ => generated 878 bytes in 39 msecs (HTTP/1.1 200) 4 headers in 185 bytes (2 switches on c
ore 0)
2016-09-14 14:06:43.688 ERROR [7fc8b8090880] (base) Unexpected exception occured
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/nailgun/api/v1/handlers/base.py", line 297, in handle_errors
    return func(cls, *args, **kwargs)
  File "<string>", line 2, in POST
  File "/usr/lib/python2.7/site-packages/nailgun/api/v1/handlers/base.py", line 355, in validate
    return func(cls, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/nailgun/api/v1/handlers/base.py", line 477, in POST
    new_obj = self.collection.create(data)
  File "/usr/lib/python2.7/site-packages/nailgun/objects/base.py", line 451, in create
    return cls.single.create(data)
  File "/usr/lib/python2.7/site-packages/nailgun/objects/plugin.py", line 51, in create
    if not graphs.get(consts.DEFAULT_DEPLOYMENT_GRAPH_TYPE):
AttributeError: 'list' object has no attribute 'get'

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/370209

Changed in fuel:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/370216

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/370209
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=ab9599d78ffe13e23101d62923d1732d745f72d6
Submitter: Jenkins
Branch: master

commit ab9599d78ffe13e23101d62923d1732d745f72d6
Author: Ilya Kutukov <email address hidden>
Date: Wed Sep 14 18:25:44 2016 +0300

    Now custom graphs delivered by plugin works properly

    There was a problem with graphs structure transformation
    in plugin adapters that was skipped during plugin creation
    because no adapter exists at that moment.

    Also, graphs declaration syntax was simplified to the

    graphs:
      - type: mygraph
      - tasks: []
      - name: graphname

    Change-Id: I2d5c8b437a1af3425af7f96e81bcf9cbace7727f
    Closes-Bug: #1623557

Changed in fuel:
status: In Progress → Fix Committed
tags: added: in-stable-mitaka
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/370216
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=542d7ce9d91a36712df363231aa671dd087b9870
Submitter: Jenkins
Branch: stable/mitaka

commit 542d7ce9d91a36712df363231aa671dd087b9870
Author: Ilya Kutukov <email address hidden>
Date: Wed Sep 14 18:25:44 2016 +0300

    Now custom graphs delivered by plugin works properly

    There was a problem with graphs structure transformation
    in plugin adapters that was skipped during plugin creation
    because no adapter exists at that moment.

    Also, graphs declaration syntax was simplified to the

    graphs:
      - type: mygraph
      - tasks: []
      - name: graphname

    Change-Id: I2d5c8b437a1af3425af7f96e81bcf9cbace7727f
    Closes-Bug: #1623557

Revision history for this message
Alexandr Kostrikov (akostrikov-mirantis) wrote :

That is blocking from any kind of usage of custom graphs.

Changed in fuel:
importance: High → Critical
Revision history for this message
Ilya Kutukov (ikutukov) wrote :

I'm reopening this bug because previous fix have not passed acceptance and this is a critical problem affecting custom graph.

Changed in fuel:
status: Fix Committed → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/370976

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/370656
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=d80d3c094857b50e527136ae3bfbc31003b3b458
Submitter: Jenkins
Branch: master

commit d80d3c094857b50e527136ae3bfbc31003b3b458
Author: Ilya Kutukov <email address hidden>
Date: Thu Sep 15 12:58:50 2016 +0300

    Fix for the plugin custom graphs installation

    Now custom graphs delivered via plugin
    working properly and have tasks.

    Closes-Bug: #1623557
    Change-Id: If5b00385ea5abce18189d5b9746b9075fe136860

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/370976
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=b3660473eeccdfae955990a95a903bf229081ea8
Submitter: Jenkins
Branch: stable/mitaka

commit b3660473eeccdfae955990a95a903bf229081ea8
Author: Ilya Kutukov <email address hidden>
Date: Thu Sep 15 12:58:50 2016 +0300

    Fix for the plugin custom graphs installation

    Now custom graphs delivered via plugin
    working properly and have tasks.

    Closes-Bug: #1623557
    Change-Id: If5b00385ea5abce18189d5b9746b9075fe136860

tags: added: feature-release-as-a-plugin
tags: added: on-verification
tags: removed: on-verification
Changed in fuel:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-web 10.0.0rc1

This issue was fixed in the openstack/fuel-web 10.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-web 10.0.0

This issue was fixed in the openstack/fuel-web 10.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.