Windows Compile Error, Float & Enum Conversions Not Allowed

[Zaren]

Using commit a76677238c6386bf7bf57e868dcd6e3f71251987, Mixxx build fails at Line 99 of .\src\library\columncache.cpp when using Visual Studio 2013 and the most recent windows_environment branch of the buildserver.

The error is:
src\library\columncache.cpp(99) : error C2440: 'static_cast' : cannot convert from 'double' to 'KeyUtils::KeyNotation'
        Conversions between enumeration and floating point values are no longer
allowed
scons: *** [win32_build\library\columncache.obj] Error 2
scons: building terminated because of errors.

Changing the ColumnCache::slotSetKeySortOrder function to use int instead of double allows the code to compile. However, I do not know how to make changes using the Git setup and I also don't have enough programming skills to understand if this would create problems further down the chain. I am just an avid home compiler, not anywhere near decent in my programming abilities.

It seems like the KeyNotation enumeration is all just basic, low value integers, so I don't see why it would make a difference.

Cheers!

[Sébastien BLAISOT (sblaisot)]

confirmed with vs2013, compiling x64 in release mode.

[Sean M. Pappalardo (pegasus-renegadetech)]

Might this explain the recent Travis failures we've been seeing?

[Be (be.ing)]

Thanks for reporting this. Sorry for breaking the build. Please try replacing src/library/columncache.cpp in your Mixxx source directory with this attachment. If it complies, please try sorting your library by key. It should start with C, then Am, then G, then Em and on around the circle of fifths.

[Zaren (czchmate)]

I didn't get a chance to try the columncache.cpp file that you posted here, but the most recent commit (dcff13a0f386d63bdb75dc1c19a489411c9e7fc9) compiled fine.

Thanks for getting to this so quickly.

Cheers!

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8642