l2pop delete_port_postcommit spam

[Kevin Benton]

Gate multinode runs filled with this:

'l2population' failed in delete_port_postcommit
2016-09-13 10:13:34.066 16443 ERROR neutron.plugins.ml2.managers Traceback (most recent call last):
2016-09-13 10:13:34.066 16443 ERROR neutron.plugins.ml2.managers File "/opt/stack/new/neutron/neutron/plugins/ml2/managers.py", line 433, in _call_on_drivers
2016-09-13 10:13:34.066 16443 ERROR neutron.plugins.ml2.managers getattr(driver.obj, method_name)(context)
2016-09-13 10:13:34.066 16443 ERROR neutron.plugins.ml2.managers File "/opt/stack/new/neutron/neutron/plugins/ml2/drivers/l2pop/mech_driver.py", line 80, in delete_port_postcommit
2016-09-13 10:13:34.066 16443 ERROR neutron.plugins.ml2.managers fdb_entries[network_id]['ports'] = other_fdb_ports
2016-09-13 10:13:34.066 16443 ERROR neutron.plugins.ml2.managers TypeError: 'NoneType' object has no attribute '__getitem__'
2016-09-13 10:13:34.066 16443 ERROR neutron.plugins.ml2.managers
2016-09-13 10:13:34.083 16443 ERROR neutron.plugins.ml2.plugin [req-6b8a08b6-76ae-42fd-a8fb-0c2ac4b

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/369382

[Assaf Muller (amuller)]

As far as I can tell there is no impact apart from scary logging, as ML2 catches mech driver exceptions.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/369382
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=6e0b8c176cfc68a9e034019a0893c8c8fbf50015
Submitter: Jenkins
Branch: master

commit 6e0b8c176cfc68a9e034019a0893c8c8fbf50015
Author: Kevin Benton <email address hidden>
Date: Tue Sep 13 02:06:28 2016 -0700

    Ensure there are fdb_entries before iterating

    _get_agent_fdb may return None so we need to check for
    that before we try to iterate over a key inside of it
    in delete_port_postcommit.

    Closes-Bug: #1622996
    Change-Id: I2256df0e08380e550f32248fb9589ee43b0923ff

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 9.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/395982

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/395982
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=0010301711b47f9bc0667a8e2e53687d2b6905db
Submitter: Jenkins
Branch: stable/mitaka

commit 0010301711b47f9bc0667a8e2e53687d2b6905db
Author: Kevin Benton <email address hidden>
Date: Tue Sep 13 02:06:28 2016 -0700

    Ensure there are fdb_entries before iterating

    _get_agent_fdb may return None so we need to check for
    that before we try to iterate over a key inside of it
    in delete_port_postcommit.

    Closes-Bug: #1622996
    Change-Id: I2256df0e08380e550f32248fb9589ee43b0923ff
    (cherry picked from commit 6e0b8c176cfc68a9e034019a0893c8c8fbf50015)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 8.4.0 release.