Make common paras graceful

Bug #1622961 reported by James Du
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Invalid
Undecided
Unassigned

Bug Description

The following parameters are assigned everywhere around the j2 files. They have same and complex value, looks ugly and is easy to make mistakes.

e.g.
    transport_url = rabbit://{% for host in groups['rabbitmq'] %}{{ rabbitmq_user }}:{{ rabbitmq_password }}@{{ hostvars[host]['ansible_' + hostvars[host]['api_interface']]['ipv4']['address'] }}:{{ rabbitmq_port }}{% if not loop.last %},{% endif %}{% endfor %}

    {% if orchestration_engine == 'KUBERNETES' %}
    auth_uri = {{ keystone_internal_url }}
    {% else %}
    auth_uri = {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}
    {% endif %}

    auth_url

    memcache_servers

    *_database_address(nova_database_address, neutron_database_address, ...)

I want to change it in this way:
    define a common parameter in all.yml, and use them around the j2 files.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on kolla (master)

Change abandoned by dupengfei (<email address hidden>) on branch: master
Review: https://review.openstack.org/369351
Reason: using dos format

Changed in kolla:
status: New → In Progress
milestone: none → newton-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by dupengfei (<email address hidden>) on branch: master
Review: https://review.openstack.org/369386
Reason: Delete this and create a bp

Revision history for this message
Steven Dake (sdake) wrote :

Marking invalid as a result of the comment in #2.

Changed in kolla:
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.