Failed to create mongodb cluster with specified 'volume_type'

[Janice-Chen]

trove cluster-create cli isn't able to create mongodb cluster instances with the specified "volume_type". and it has the same prombles with other datastore,eg:redis.

Since trove cluster-create API allows to pass "volume_type" as one of parameters,when use "trove cluster-create" command to create a mongodb cluster,all of the instances created successfully but does not use the specified volume type.

CLI view:
[root@controller /]# trove help cluster-create
usage: trove cluster-create <name> <datastore> <datastore_version>
                            [--instance "<opt=value,opt=value,...>"]

Creates a new cluster.

Positional arguments:
  <name> Name of the cluster.
  <datastore> A datastore name or ID.
  <datastore_version> A datastore version name or ID.

Optional arguments:
  --instance "<opt=value,opt=value,...>"
                                  Create an instance for the cluster. Specify
                                  multiple times to create multiple instances.
                                  Valid options are: flavor=flavor_name_or_id,
                                  volume=disk_size_in_GB, volume_type=type,
                                  nic='net-id=net-uuid,v4-fixed-ip=ip-addr
                                  ,port-id=port-uuid' (where net-id=network_id,
                                  v4-fixed-ip=IPv4r_fixed_address, port-id=port_id),
                                  availability_zone=AZ_hint_for_Nova.

As you can see, 'volume_type=type' can be passed through.

see also https://blueprints.launchpad.net/trove/+spec/volume-type-on-create).

[Amrith Kumar (amrith)]

How is this different from https://bugs.launchpad.net/trove/+bug/1623005?

[jian.song (jiansong)]

I found this bug, it seems that he still has the meaning of renewal. Next to explain why:
1. Although we parse the type, but not in the cluster creation process will be passed to instance-create:
https://github.com/openstack/trove/blob/master/trove/common/strategies/cluster/experimental/galera_common/api.py#L111

2. After the above problem is solved, we need to face the problem is, create can deliver volume_type, the same, grow should also need this parameter.

I will have recently modified this question

[jian.song (jiansong)]

this is grow analysis
https://github.com/openstack/trove/blob/master/trove/cluster/models.py#L312

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/513276

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/514115

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/513276
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=6060dacde91f330e1c1ac3df540273238227036f
Submitter: Zuul
Branch: master

commit 6060dacde91f330e1c1ac3df540273238227036f
Author: jiansong <email address hidden>
Date: Wed Oct 18 23:31:12 2017 -0700

    cluster-create support volume_type

    Now we just parse the volume_type parameter in cluster/service.py,
    but it is not passed in the creat instance, which will be
    supported here.

    Change-Id: Iae790e54ebf1bd6cb968c3be4c3f5cd53e1082f7
    Partial-Bug: #1622957