Use unique names for event strings

Bug #1622698 reported by Tyr Johanson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Confirmed
Wishlist
Unassigned

Bug Description

Angular widgets that listen for or dispatch events have the possibility of accidentally picking up the wrong event unless the event string is unique.

For example, see https://review.openstack.org/#/c/321132/8/horizon/static/framework/widgets/magic-search/magic-search.module.js

"textSearch" is fairly generic, and might collide with another component accidentally.

Consider instead including the module name as part of the event string.

For example: "horizon.framework.widgets.magic-search.events.textSearch"

tamil vanan (tamilhce)
Changed in horizon:
assignee: nobody → tamil vanan (tamilhce)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/369226

tamil vanan (tamilhce)
Changed in horizon:
status: New → In Progress
Changed in horizon:
assignee: tamil vanan (tamilhce) → nobody
status: In Progress → Confirmed
importance: Undecided → Wishlist
milestone: none → next
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Rob Cresswell (<email address hidden>) on branch: master
Review: https://review.openstack.org/369226
Reason: Due to inactivity

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.