Particular core and extension nailgun methods have diverged interfaces and are loop-prone

Bug #1621851 reported by Vladimir Kuklin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Bulat Gaifullin

Bug Description

Some of the methods working with extensions have been altered and do not call extensions which extend their results with the same set of parameters. Also, it extensions can call other methods which call extensions, which is loop-prone and we should allow a developer to avoid these loops by telling certain methods to disable extensions call.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/367999

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/367999
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=585b9f59749b9fbffcb22790b6200e7fd11b93b0
Submitter: Jenkins
Branch: master

commit 585b9f59749b9fbffcb22790b6200e7fd11b93b0
Author: Bulat Gaifullin <email address hidden>
Date: Fri Sep 9 16:07:38 2016 +0300

    Fixed problems prevented for calling core serializers from extensions.

    Added option skip_extensions for core-serializers, to prevent
    loop when core-serializer is called from extension.
    Also method process_'deployment_for_node' does not have access
    to cluster_info and it is not possible to call 'serialize_node'
    from extension because cluster_info was mandatory argument.
    Because 'cluster_info' was needed only for provision serialzer,
    which is called from LCM serializer, this argument was removed
    from serialze_node method.

    Change-Id: Ifbf9e4a0b9487605e6268fde0499aecc1e20cb36
    Closes-Bug: 1621851

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/369549

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/369549
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=a7ef3215bac29a2d5710465811afa1b26155075b
Submitter: Jenkins
Branch: stable/mitaka

commit a7ef3215bac29a2d5710465811afa1b26155075b
Author: Bulat Gaifullin <email address hidden>
Date: Fri Sep 9 16:07:38 2016 +0300

    Fixed problems prevented for calling core serializers from extensions.

    Added option skip_extensions for core-serializers, to prevent
    loop when core-serializer is called from extension.
    Also method process_'deployment_for_node' does not have access
    to cluster_info and it is not possible to call 'serialize_node'
    from extension because cluster_info was mandatory argument.
    Because 'cluster_info' was needed only for provision serialzer,
    which is called from LCM serializer, this argument was removed
    from serialze_node method.

    Change-Id: Ifbf9e4a0b9487605e6268fde0499aecc1e20cb36
    Closes-Bug: 1621851

tags: added: in-stable-mitaka
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-web 10.0.0rc1

This issue was fixed in the openstack/fuel-web 10.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-web 10.0.0

This issue was fixed in the openstack/fuel-web 10.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.