minimise round_timestamp calculations
Bug #1621510 reported by
gordon chung
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Gnocchi |
Fix Released
|
Wishlist
|
gordon chung | ||
Bug Description
this is sort of related to bug 1621498.
basically, we are calculating round_timestamp quite a bit and more often then not for the same timestamps. for example, we calculate this for each aggregate+sampling but it should only be different per sampling[1]. similarly, it's the same timestamps for each split per sampling and same groupby times per sampling. this second case can probably be handled by bug 1621498.
i think it'd be good to start caching the results possibly?
| Changed in gnocchi: | |
| status: | New → Triaged |
| importance: | Undecided → Wishlist |
| description: | updated |
| Changed in gnocchi: | |
| assignee: | nobody → gordon chung (chungg) |
| status: | Triaged → In Progress |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to gnocchi (master) | #1 |
| Changed in gnocchi: | |
| status: | In Progress → Fix Committed |
| Changed in gnocchi: | |
| milestone: | none → 3.0.0 |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 8abc05b22ad541d
Author: gord chung <email address hidden>
Date: Fri Sep 9 20:37:28 2016 +0000
share groupings across aggregates
this changes it so we don't compute a completely new series over
and over for each aggregte when in reality, they are all the same.
should save on round_timestamp calculations as well.
Change-Id: I525fe97b2674ea
Closes-Bug: #1621498
Closes-Bug: #1621510