tripleo

M/N upgrade upgrade-non-controller.sh doesn't fail if the triggered script fails

Bug #1620973 reported by Sofer Athlan-Guyot
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Sofer Athlan-Guyot
tripleo newton-rc2 "newton-rc2"

Bug Description

Hi,

Running:

  upgrade-non-controller.sh --upgrade overcloud-objectstorage-0

I've got an error but the exit code of the above command was 0 instead of 1. This make it hard to detect error in ci.

Tags: upgrade-bugs
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/366623

Changed in tripleo:
assignee: nobody → Sofer Athlan-Guyot (sofer-athlan-guyot)
status: New → In Progress
James Slagle (james-slagle)
Changed in tripleo:
milestone: none → newton-rc2
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/366623
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=bc7f6ab041f1d7c4de003e93373ad6ed3aa47f87
Submitter: Jenkins
Branch: master

commit bc7f6ab041f1d7c4de003e93373ad6ed3aa47f87
Author: Sofer Athlan-Guyot <email address hidden>
Date: Wed Sep 7 11:25:41 2016 +0200

    Make sure major upgrade script fails.

    Running upgrade-non-controller.sh against compute and object storage did
    not fail if the /root/tripleo_upgrade_node.sh failed.

    This make it harder to detect error in CI system for instance.

    Change-Id: I12b7d640547d3b8ec1f70104d159d6052b7638ff
    Closes-Bug: 1620973

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 5.0.0.0rc2

This issue was fixed in the openstack/tripleo-heat-templates 5.0.0.0rc2 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.