Help message for muranoclient usage with options murano-packages-service glance isn't clear

Bug #1620816 reported by Ilya Popov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-muranoclient
Opinion
Low
Ilya Popov

Bug Description

separated messages should been created for murano-packages-service glance and murano-packages-service glare options

Revision history for this message
Ilya Popov (ilya-p) wrote :

it is about help messages for python-muranoclient

Changed in python-muranoclient:
assignee: nobody → Ilya Popov (ilya-p)
Revision history for this message
Kirill Zaitsev (kzaitsev) wrote :

I'm not really sure what you mean by this. In any case glare is no longer part of glance, so 'glance' parameter is deprecated and will be removed in Ocata or P cycle

Changed in python-muranoclient:
status: New → Opinion
Revision history for this message
Ilya Popov (ilya-p) wrote :

Kirill,

sure, bug description isn't very clear.

I mean the following:

            if (not args.glare_url and
                    args.murano_packages_service in ['glance', 'glare']):
                raise exc.CommandError(
                    "If you specify --os-no-client-auth and"
                    " set murano-packages-service to 'glance'"
                    " you must also specify a glance glare API URL"
                    " via either --glare-url or env[GLARE_API]")

The same error message will appear for both "glare" and "glance" options chosen. My opinion is to set different error message for "glance" and "glare" while both options exist in parser.

Ilya Popov (ilya-p)
Changed in python-muranoclient:
status: Opinion → New
Changed in python-muranoclient:
status: New → Confirmed
importance: Undecided → Low
milestone: none → 0.11.1
Changed in python-muranoclient:
status: Confirmed → In Progress
Ilya Popov (ilya-p)
Changed in python-muranoclient:
status: In Progress → Opinion
Revision history for this message
Kirill Zaitsev (kzaitsev) wrote :

> The same error message will appear for both "glare" and "glance" options chosen. My opinion is to set different error message for "glance" and "glare" while both options exist in parser.

That's because those two options basically mean the same

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-muranoclient (master)

Change abandoned by zhurong (<email address hidden>) on branch: master
Review: https://review.openstack.org/366738
Reason: Patch has Merge Conflict and hasn't been updated for a long time. Feel free to restore this if you want.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.