When release plugin is enabled, environment can not be created

Bug #1620645 reported by Alexandr Kostrikov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Critical
Vladimir Kuklin

Bug Description

[root@nailgun fuel-plugins]# fuel env create --rel 2 --name lol
500 Server Error: Internal Server Error for url: http://10.109.5.2:8000/api/v1/clusters/ (Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/nailgun/api/v1/handlers/base.py", line 293, in handle_errors
    return func(cls, *args, **kwargs)
  File "<string>", line 2, in POST
  File "/usr/lib/python2.7/site-packages/nailgun/api/v1/handlers/base.py", line 351, in validate
    return func(cls, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/nailgun/api/v1/handlers/base.py", line 474, in POST
    new_obj = self.collection.create(data)
  File "/usr/lib/python2.7/site-packages/nailgun/objects/base.py", line 451, in create
    return cls.single.create(data)
  File "/usr/lib/python2.7/site-packages/nailgun/objects/cluster.py", line 195, in create
    ClusterPlugin.add_compatible_plugins(cluster)
  File "/usr/lib/python2.7/site-packages/nailgun/objects/plugin.py", line 216, in add_compatible_plugins
    for plugin in cls.get_compatible_plugins(cluster):
  File "/usr/lib/python2.7/site-packages/nailgun/objects/plugin.py", line 207, in get_compatible_plugins
    PluginCollection.all()))
  File "/usr/lib/python2.7/site-packages/nailgun/objects/plugin.py", line 206, in <lambda>
    lambda p: cls.is_compatible(cluster, p),
  File "/usr/lib/python2.7/site-packages/nailgun/objects/plugin.py", line 194, in is_compatible
    return plugin_adapter.validate_compatibility(cluster)
  File "/usr/lib/python2.7/site-packages/nailgun/plugins/adapters.py", line 236, in validate_compatibility
    if cluster_os != release['os'].lower():
KeyError: 'os'
)

The lines are:
        cluster_os = cluster.release.operating_system.lower()
        for release in self.plugin.releases:
            if cluster_os != release['os'].lower():
                continue

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/366181

Changed in fuel:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/366183

tags: added: feature-release-as-a-plugin
Changed in fuel:
assignee: Ilya Kutukov (ikutukov) → Vladimir Kuklin (vkuklin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/366181
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=ff1e8b26970e6728d0c5c05866bb0935108195f1
Submitter: Jenkins
Branch: master

commit ff1e8b26970e6728d0c5c05866bb0935108195f1
Author: Ilya Kutukov <email address hidden>
Date: Tue Sep 6 17:57:54 2016 +0300

    operating_system field processed correctly and release enabled by default

    Closes-bug: #1620645
    Closes-bug: #1620646

    Change-Id: I28c5435e5203c40689393f0327d84fadbe0c9d3d

Changed in fuel:
status: In Progress → Fix Committed
tags: added: on-verification
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/366183
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=899307cefeca1beed978fb98a6e0aedf8931a193
Submitter: Jenkins
Branch: stable/mitaka

commit 899307cefeca1beed978fb98a6e0aedf8931a193
Author: Ilya Kutukov <email address hidden>
Date: Tue Sep 6 17:57:54 2016 +0300

    operating_system field processed correctly and release enabled by default

    Closes-bug: #1620645
    Closes-bug: #1620646

    Change-Id: I28c5435e5203c40689393f0327d84fadbe0c9d3d

tags: added: in-stable-mitaka
Changed in fuel:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-web 10.0.0rc1

This issue was fixed in the openstack/fuel-web 10.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-web 10.0.0

This issue was fixed in the openstack/fuel-web 10.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.