[2.1, UI] Broken validation on VLAN MTU
Bug #1620478 reported by
Gavin Panella
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
Critical
|
Blake Rouse |
Bug Description
Moving the focus into a VLAN's MTU field then tabbing out results in a
validation error:
primary_rack: Select a valid choice. 1 is not one of
the available choices.
See attached screenshot.
Using 2.1.0~alpha2+
Related branches
lp:~blake-rouse/maas/fix-1620478
- Mike Pontillo (community): Approve
-
Diff: 564 lines (+88/-174)7 files modifiedsrc/maasserver/models/tests/test_vlan.py (+1/-71)
src/maasserver/models/vlan.py (+0/-47)
src/maasserver/static/js/angular/controllers/node_details_networking.js (+4/-4)
src/maasserver/static/js/angular/controllers/tests/test_vlan_details.js (+4/-12)
src/maasserver/static/js/angular/controllers/vlan_details.js (+4/-4)
src/maasserver/websockets/handlers/tests/test_vlan.py (+51/-23)
src/maasserver/websockets/handlers/vlan.py (+24/-13)
tags: | added: error-surface |
Changed in maas: | |
importance: | Undecided → Critical |
milestone: | none → 2.1.0 |
status: | New → Triaged |
summary: |
- [UI] Broken validation on VLAN MTU + [2.1, UI] Broken validation on VLAN MTU |
Changed in maas: | |
milestone: | 2.1.0 → 2.1.1 |
Changed in maas: | |
status: | Triaged → In Progress |
assignee: | nobody → Blake Rouse (blake-rouse) |
Changed in maas: | |
status: | In Progress → Fix Committed |
Changed in maas: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Actually in this case the validation is not wrong. There is an issue with your configuration as MAAS now believed that your rack controller cannot control that VLAN. I would assume that means your rack interface was changed to a different interface while controlling that VLAN.
There is a bigger issue here really. When a rack controller is the primary or secondary controller for a VLAN its interfaces should not be allowed to be changed where that rack controller would be disconnected from the VLAN it is controlling, either by user action or automatically. The automatic case is the hardest when something like that occurs we need to perform some action to alert the user that on of the rack controllers that should be running this VLAN no longer can, so either MAAS automatically picks a new rack controller that can manage the VLAN or we disable DHCP and alert the user.