[nailgun] Nailgun returns Internal Server Error while trying to get the list of available extensions

[Vitalii Kulanov]

Detailed bug description:
A new API handler /extensions/ (returns a list of available extensions) was added recently https://review.openstack.org/#/c/362842/, but if we try to use it (e.g. get list of available extensions) Nailgun reports 'Internal server error'.

curl -s -H "X-Auth-Token: $AUTH_TOKEN" http://10.20.0.2:8000/api/v1/extensions
internal server error

Nailgun logs:

[root@fuel ~]# tail /var/log/nailgun/api.log -n 50

2016-09-05 20:49:49.169 DEBUG [7f1839cbe880] (logger) Request GET /api/v1/extensions from 10.20.0.1:46888
2016-09-05 20:49:49.171 ERROR [7f1839cbe880] (logger) Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/web/application.py", line 239, in process
    return self.handle()
  File "/usr/lib/python2.7/site-packages/web/application.py", line 230, in handle
    return self._delegate(fn, self.fvars, args)
  File "/usr/lib/python2.7/site-packages/web/application.py", line 420, in _delegate
    return handle_class(cls)
  File "/usr/lib/python2.7/site-packages/web/application.py", line 396, in handle_class
    return tocall(*args)
  File "<string>", line 2, in GET
  File "/usr/lib/python2.7/site-packages/nailgun/api/v1/handlers/base.py", line 381, in serialize
    resp = func(cls, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/nailgun/api/v1/handlers/extension.py", line 30, in GET
    return [ext.to_dict() for ext in get_all_extensions()]
TypeError: unbound method to_dict() must be called with NetworkManagerExtension instance as first argument (got nothing instead)

2016-09-05 20:49:49.172 ERROR [7f1839cbe880] (logger) Response code '500 Internal Server Error' for GET /api/v1/extensions from 10.20.0.1:46888

Steps to reproduce:
1. Deploy Fuel (e.g. 1 master + 5 nodes).
2. Create new env.
6. Try to get the list of available extensions for the cluster
   curl -s -H "X-Auth-Token: $AUTH_TOKEN" http://10.20.0.2:8000/api/v1/extensions

Expected results:
 List of available extensions

Actual result:
 Interanal Server Error

Reproducibility:
 Always

Description of the environment:
[root@fuel ~]# shotgun2 short-report
cat /etc/fuel_build_id:
 607
cat /etc/fuel_build_number:
 607
cat /etc/fuel_release:
 10.0
cat /etc/fuel_openstack_version:
 newton-10.0

Additional information:
 Reproduced in newton and mitaka (https://review.openstack.org/#/q/I072f3e4d9cd8f71498a20312af7c2016e951456d,n,z)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/366026

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/366026
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=d96e29d04429eb05f806337874a2f755c8c608a5
Submitter: Jenkins
Branch: master

commit d96e29d04429eb05f806337874a2f755c8c608a5
Author: tivaliy <email address hidden>
Date: Tue Sep 6 13:04:00 2016 +0300

    Align code for Extension Handler

    Change-Id: Ie9a47f8ba8879eea9afd8368c6ef195ef15f7c8d
    Closes-Bug: 1620463

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/367290

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/367290
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=ed765b959abf0eb435cd3831be7ce317b9022410
Submitter: Jenkins
Branch: stable/mitaka

commit ed765b959abf0eb435cd3831be7ce317b9022410
Author: tivaliy <email address hidden>
Date: Tue Sep 6 13:04:00 2016 +0300

    Align code for Extension Handler

    Change-Id: Ie9a47f8ba8879eea9afd8368c6ef195ef15f7c8d
    Closes-Bug: 1620463
    (cherry picked from commit d96e29d04429eb05f806337874a2f755c8c608a5)

[TatyanaGladysheva (tgladysheva)]

Verified on 9.1 snapshot #281.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-web 10.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-web 10.0.0 release.

[Dmitry Belyaninov (dbelyaninov)]

Verified on Newton #1556 iso.

[root@nailgun ~]# curl -s -H "X-Auth-Token: 60d0e6062dad43078cd8bfa3f9d68751" http://10.109.0.2:8000/api/v1/extensions
[{"version": "1.0.0", "name": "network_manager", "provides": [], "description": "Network Manager"}, {"version": "1.0.0", "name": "volume_manager", "provides": ["get_node_volumes", "set_node_volumes", "set_default_node_volumes"], "description": "Volume Manager Extension"}][root@nailgun ~]#