Plugin_example system tests failed on step of checking fuel-simple-service

[ElenaRossokhina]

Detailed bug description:
Several tests failed (one of example) in swarm:
https://product-ci.infra.mirantis.net/job/9.x.system_test.ubuntu.plugins.install_plugin_after_cluster_create/51/testReport/(root)/five_ctrl_enable_installed_after_create_add/
9.1 snapshot 221
Steps to reproduce:
Scenario:
        1. Enable plugin
        2. Deploy 2 new controller nodes at cluster (Nodes Under Test)
        3. Run network verification
        4. Check plugin on ALL controller nodes << fail
        5. Run OSTF
Expected results:
pass
Actual result:
checking is failed:
2016-09-05 03:19:38 - ERROR - ssh_client.py:580 -- Command 'pgrep -f fuel-simple-service' returned exit code 1 while expected [0]

https://drive.google.com/open?id=0B2ag_Bf-ShtTSHp1MllSS1dsUkk

[ElenaRossokhina (esolomina)]

Also failed on that run:
https://product-ci.infra.mirantis.net/job/9.x.system_test.ubuntu.plugins.install_plugin_after_cluster_create/51/testReport/(root)/three_ctrl_enable_installed_after_create_redeploy/
https://product-ci.infra.mirantis.net/job/9.x.system_test.ubuntu.plugins.install_plugin_after_cluster_create/51/testReport/(root)/five_ctrl_enable_installed_after_deploy_add/
https://product-ci.infra.mirantis.net/job/9.x.system_test.ubuntu.plugins.install_plugin_after_cluster_create/51/testReport/(root)/three_ctrl_enable_installed_after_deploy_redeploy/
https://product-ci.infra.mirantis.net/job/9.x.system_test.ubuntu.plugins.install_plugin_after_cluster_create/51/testReport/(root)/three_ctrl_install_enable_after_create/

[Alexander Kurenyshev (akurenyshev)]

If the service `fuel-simple-service` is not running it is a problem with it's deploying, than the plugin was not correctly installed. We need to check the plugin deployment tasks.

[Dmitry Pyzhov (dpyzhov)]

Broken installation of the example plugin cannot be counted as critical issue. Example of critical issue: installation of ANY plugin is broken.

[Georgy Kibardin (gkibardin)]

Post deploy task with "bash deploy.sh" is not in the graph for some reason.

[Georgy Kibardin (gkibardin)]

The task which deploy the service is executed on node with role fuel_plugin_example_v4. I don't see any node with such role in the snapshot.

[Georgy Kibardin (gkibardin)]

There is no such code in https://github.com/openstack/fuel-qa/blob/master/fuelweb_test/tests/plugins/plugin_example/test_fuel_plugin_example_postdeploy.py
i.e. the role is not set and the task isn't run.

[Alexander Kurenyshev (akurenyshev)]

As I see at the old tasks.yaml from plugin_v3 [1] it was not supposed to add new role with standalone plugin, all related to the fuel-simple-service tasks were executed on controllers.
For some reasons we have changed this behavior and moved that tasks to the imaginary role `fuel_plugin_example_v3` [2] and role `fuel_plugin_example_v4` [3].

We need to return all related plugin tasks to the controller role.

[1] https://github.com/openstack/fuel-plugins/blob/master/examples/fuel_plugin_example_v3/tasks.yaml#L2
[2] https://github.com/openstack/fuel-plugins/blob/master/examples/fuel_plugin_example_v3/deployment_tasks.yaml#L36
[3] https://github.com/openstack/fuel-plugins/blob/master/examples/fuel_plugin_example_v4/deployment_tasks.yaml#L39

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/374135

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/374141

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/374141
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=18653a93de6175e6b031514cc7376cdb6b87eb52
Submitter: Jenkins
Branch: stable/mitaka

commit 18653a93de6175e6b031514cc7376cdb6b87eb52
Author: Alexander Kurenyshev <email address hidden>
Date: Wed Sep 21 16:12:00 2016 +0300

    Fix plugin v3 and v4 hotplug tests

    The example plugin v3 has not legacy tasks
    that's why propagate_task_deploy should not
    be introduced.

    The plugin v4 should be installed at the
    new introduced by plugin role fuel_plugin_example_v4
    and should be checked under that role.
    The controller role is not affected by plugin v4,
    so, it was decided to disable 2 tests in which
    we re-deploy controller node.

    Change-Id: I13eb7d7189421b8ae82410866440cba2052fac69
    Closes-Bug:1620325

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/374135
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=27f0e7b85183f50d3c8423c54311e74b6719e84e
Submitter: Jenkins
Branch: master

commit 27f0e7b85183f50d3c8423c54311e74b6719e84e
Author: Alexander Kurenyshev <email address hidden>
Date: Wed Sep 21 16:12:00 2016 +0300

    Fix plugin v3 and v4 hotplug tests

    The example plugin v3 has not legacy tasks
    that's why propagate_task_deploy should not
    be introduced.

    The plugin v4 should be installed at the
    new introduced by plugin role fuel_plugin_example_v4
    and should be checked under that role.
    The controller role is not affected by plugin v4,
    so, it was decided to disable 2 tests in which
    we re-deploy controller node.

    Change-Id: I13eb7d7189421b8ae82410866440cba2052fac69
    Closes-Bug:1620325

[ElenaRossokhina (esolomina)]

verified on 9.1 snapshot #299