Negative block_instance sortorders

[Ghada El-Zoghbi]

Mahara: 15.10.5
DB: MySql
OS: Linux
Browser: FF

The issue of negative sort order has reappeared again after the upgrade went through the script for 'Sorting out block_instance sort order drift'.

When trying to edit a page, it generates the following errors:

[WAR] a6 (lib/view.php:1946) Undefined offset: 2
Call stack (most recent first):

    log_message("Undefined offset: 2", 8, true, true, "/var/www/mahara/htdocs/lib/view.php", 1946) at /var/www/mahara/htdocs/lib/errors.php:515
    error(8, "Undefined offset: 2", "/var/www/mahara/htdocs/lib/view.php", 1946, array(size 6)) at /var/www/mahara/htdocs/lib/view.php:1946
    View->build_column_datastructure(2, false) at /var/www/mahara/htdocs/lib/view.php:1983
    View->get_row_datastructure() at /var/www/mahara/htdocs/lib/view.php:2367
    View->get_all_blocktype_css() at /var/www/mahara/htdocs/view/blocks.php:133

[WAR] a6 (lib/view.php:1946) Trying to get property of non-object
Call stack (most recent first):

    log_message("Trying to get property of non-object", 8, true, true, "/var/www/mahara/htdocs/lib/view.php", 1946) at /var/www/mahara/htdocs/lib/errors.php:515
    error(8, "Trying to get property of non-object", "/var/www/mahara/htdocs/lib/view.php", 1946, array(size 6)) at /var/www/mahara/htdocs/lib/view.php:1946
    View->build_column_datastructure(2, false) at /var/www/mahara/htdocs/lib/view.php:1983
    View->get_row_datastructure() at /var/www/mahara/htdocs/lib/view.php:2367
    View->get_all_blocktype_css() at /var/www/mahara/htdocs/view/blocks.php:133

And, users aren't able to edit the layout. They get the following warning:

Could not change the column layout. Someone else may have been editing the layout at the same time. Please try again later.

I haven't been able to pinpoint the cause of the error.

Bug #1613135 tried to fix the existing data. Unfortunately, the underlying issue still seems to exist.

[Ghada El-Zoghbi (ghada-z)]

Update:

This may have been an issue due to a customization in the upgrade script for this client. We found a bug in the upgrade script.

I have checked their DB and there are no negative block_instance order columns any more.

Probably best to cancel this bug.

Sorry...
Ghada