Murano PL blank error message with arg format error

[Mark Endrei]

Hello,

I get the following blank dashboard error message when deploying an app with a Murano PL class that has more than one method argument without the hyphen:

2016-09-04 04:42:55 — Action deploy is scheduled
2016-09-04 04:42:57 — Deployment finished with errors
2016-09-04 04:42:57 —

It can be reproduced with the following example method:

...
  print:
    Arguments:
      message:
        Contract: $.string().notNull()
      message2:
        Contract: $.string().notNull()
    Body:
      - $._environment.reporter.report($this, format('{0},{1}',$message,$message2))
...

A descriptive message would make it easier to debug this syntax error, especially because one argument without hyphen is fine, eg.

  print:
    Arguments:
      message:
        Contract: $.string().notNull()
    Body:
      - $._environment.reporter.report($this, $message))

Thanks, Mark

[Mark Endrei (markendr)]

We are on Mitaka

[Valerii Kovalchuk (vakovalchuk)]

I've added your method to my app and deployment gives me the following log:
2016-09-06 13:50:47 — Action deploy is scheduled
2016-09-06 13:50:52 — Invalid arguments declaration
2016-09-06 13:50:52 — Deployment finished with errors

So the error message is not blank.

Can you share your application code somehow to examine it?

[Valerii Kovalchuk (vakovalchuk)]

I'm using murano from master though. Will try it on mitaka

[Mark Endrei (markendr)]

I added the method above to the ApacheHTTPServer package from the app catalog to repeat/confirm the problem on mitaka. Please find attached.

Great if it is already fixed in master

Cheers, Mark

[Valerii Kovalchuk (vakovalchuk)]

@Mark: the bug was fixed in master by the patch https://review.openstack.org/#/c/310055/7/murano/dsl/murano_method.py

Unfortunately the fix cannot be backported to stable/mitaka branch, because it was done as a part of the feature. You can fix it yourself by applying the following lines from the patch above (lines 92-94 in murano_method.py file):

if not isinstance(record, dict) or len(record) > 1:
    raise exceptions.DslSyntaxError(
        'Invalid arguments declaration')

instead of the empty ValueError in mitaka

[Mark Endrei (markendr)]

@Valerii: thanks for confirming it is fixed in master, and for the fix details. I will raise with our operations team to see if they want to patch.