use-floating-ip is not honored from clouds.yaml config

[Francis Ginther]

I have a cloud configuration file with a config section that includes "use-floating-ip: true". This is allowed according to https://bugs.launchpad.net/juju/+bug/1576750. However, when bootstraping, a floating-ip is not used. It is used when specified with the config option:

ubuntu@juju2-b17:~$ juju --version
2.0-beta17-xenial-amd64
# Also saw with beta16

[.local//clouds.yaml]
ubuntu@juju2-b17:~/.local/share/juju$ cat clouds.yaml
clouds:
  cloud1-region1:
    type: openstack
    auth-types: [userpass]
    regions:
      region1:
        endpoint: http://10.2.0.9:5000/v2.0
    config:
      use-floating-ip: true

[failed attempt]
ubuntu@juju2-b17:~/inner$ juju-2.0 bootstrap controller_name cloud1-region1
Creating Juju controller "controller_name" on cloud1-region1/region1
Looking for packaged Juju agent version 2.0-beta17 for amd64
Launching controller instance(s) on cloud1-region1/region1...
 - f332bd5f-d199-4da2-af4a-d4290ed153d9
Fetching Juju GUI 2.1.10
Waiting for address
Attempting to connect to 10.10.0.4:22
WARNING cannot delete security group "juju-8a2c9dc8-0e57-4826-8d29-aa32ec7e8245-8a2c9dc8-0e57-4826-8d29-aa32ec7e8245-0". Used by another model?
WARNING cannot delete security group "juju-8a2c9dc8-0e57-4826-8d29-aa32ec7e8245-8a2c9dc8-0e57-4826-8d29-aa32ec7e8245". Used by another model?
WARNING cannot delete security group "juju-8a2c9dc8-0e57-4826-8d29-aa32ec7e8245-8a2c9dc8-0e57-4826-8d29-aa32ec7e8245-0". Used by another model?
WARNING cannot delete security group "juju-8a2c9dc8-0e57-4826-8d29-aa32ec7e8245-8a2c9dc8-0e57-4826-8d29-aa32ec7e8245". Used by another model?
WARNING cannot delete security group "juju-8a2c9dc8-0e57-4826-8d29-aa32ec7e8245-8a2c9dc8-0e57-4826-8d29-aa32ec7e8245-0". Used by another model?
ERROR failed to bootstrap model: waited for 20m0s without being able to connect: ssh_exchange_identification: Connection closed by remote host

[more successful attempt with config option specified]
ubuntu@juju2-b17:~/inner$ juju-2.0 bootstrap controller_name cloud1-region1 --config use-floating-ip=true
Creating Juju controller "controller_name" on cloud1-region1/region1
Looking for packaged Juju agent version 2.0-beta17 for amd64
Launching controller instance(s) on cloud1-region1/region1...
 - ff3904b1-890d-4dce-9712-bb040b8829a0
Fetching Juju GUI 2.1.10
Waiting for address
Attempting to connect to 10.2.200.104:22
Attempting to connect to 10.10.0.5:22
sudo: unable to resolve host juju-68861659-bf40-47a2-8591-c98160834f25-machine-0
Logging to /var/log/cloud-init-output.log on the bootstrap machine
Running apt-get update
Running apt-get upgrade
Installing curl, cpu-checker, bridge-utils, cloud-utils, tmux
Fetching Juju agent version 2.0-beta17 for amd64
Installing Juju machine agent
...

[Andreas Hasenack (ahasenack)]

You can test this using canonistack if you prefer:

This way it works:

juju bootstrap canonistack/lcy02 --config use-floating-ip=true

This way, in the config file used to ingest the cloud, it doesn't:

    canonistack:
        type: openstack
        auth-types: [userpass]
        config:
            use-floating-ip: true
        regions:
            lcy01:
                endpoint: https://keystone.canonistack.canonical.com:443/v2.0/
            lcy02:
                endpoint: https://keystone.canonistack.canonical.com:443/v2.0/