cinder os-force_detach action api 202 accepted even if required "connector" parameter is not passed in request body

[Bhagyashri Shewale]

In case of "lvm" backend if user does not passed "connector" parameter in the request body of "os-force_detach" action api then it returns the 202 accepted but as per the api-ref document [1] "connector" is the mandatory parameter, so in this case it should return 400 BadRequest.

Input:

curl -g -i -X POST http://172.26.88.24:8776/v2/5616418a7be141c3a701791540703f55/volumes/65f02c4d-d46c-43d5-a7ee-00b9c33dfa9a/action -H "User-Agent: python-cinderclient" -H "Content-Type: application/json" -H "Accept: application/json" -H "X-Auth-Token: a2cdc6a42c198c4fa0a7a453d85c4894dc97df76" -d '{"os-force_detach": {}}'

OutPut:

HTTP/1.1 202 Accepted
Content-Type: text/html; charset=UTF-8
Content-Length: 0
X-Openstack-Request-Id: req-e345b370-ed9a-4c37-a7c7-54ea325f0769
Date: Fri, 02 Sep 2016 09:12:54 GMT

[1] http://developer.openstack.org/api-ref-blockstorage-v2.html

[luqitao (qtlu)]

This bug has been fixed in master branch

[Gorka Eguileor (gorka)]

It is not actually fixed in master even though the try...except may make us think so.

[Scott DAngelo (scott-dangelo)]

Is this a bug in the code or a bug in the api reference?
One of the purposes of force-detach is to help the admin clean up if things are in a bad state, so there might not be a connector to pass in. This is the case if Cinder thinks the volume is attached but the Nova instance has already been deleted.
The fix for this should probably be to correct the api-reference.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/466165

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/466165
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=00edd490c6789f16d6eb5c4952308c9f5131b8eb
Submitter: Jenkins
Branch: master

commit 00edd490c6789f16d6eb5c4952308c9f5131b8eb
Author: luqitao <email address hidden>
Date: Thu May 18 23:10:01 2017 -0400

    Make "connector" param to be optional in force-detach api

    One of the purposes of force-detach is to help the admin clean up
    if things are in a bad state, so there might not be a connector to
    pass in. This is the case if Cinder thinks the volume is attached
    but the Nova instance has already been deleted.

    Change-Id: I417ed7b100dfe8402599028597511949e00725ac
    Closes-Bug: #1619647

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 11.0.0.0b2 development milestone.