It looks like old version of fuel_syntax_check.sh is used in stable/7.0 branch of fuel-library. There is no recent patches like https://review.openstack.org/#/c/342896/ there. At the same time it looks like puppet manifests checks generate puppet4 specific errors (see below). Please investigate.
Checking /home/jenkins/workspace/old.fuellib_review_syntax_check/deployment/puppet/ceph
Using rake lint
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...
Using rake 11.2.2
Using CFPropertyList 2.2.8
Using diff-lcs 1.2.5
Using facter 2.4.6
Using json_pure 2.0.2
Using hiera 1.3.4
Using metaclass 0.0.4
Using mocha 1.1.0
Using puppet 3.8.7
Using puppet-lint 0.3.2
Using puppet-syntax 2.1.0
Using rspec-support 3.5.0
Using rspec-core 3.5.2
Using rspec-expectations 3.5.0
Using rspec-mocks 3.5.0
Using rspec 3.5.0
Using rspec-puppet 2.1.0
Using puppetlabs_spec_helper 1.1.1
Using bundler 1.7.6
Your bundle is updated!
** Invoke lint (first_time)
** Execute lint
manifests/osds/osd.pp - WARNING: defined type not documented on line 1
Error: Could not parse for environment production: This Array Expression has no effect. A Host Class Definition can not end with a value-producing expression without other effect at /home/jenkins/workspace/old.fuellib_review_syntax_check/deployment/puppet/ceph/manifests/radosgw.pp:237:11
FAILED checking ./manifests/radosgw.pp, return code was 1
Checking /home/jenkins/workspace/old.fuellib_review_syntax_check/deployment/puppet/galera
Using puppet-lint
./manifests/init.pp - WARNING: class included by relative name on line 106
./manifests/init.pp - WARNING: missing documentation for class parameter galera::use_syslog on line 93
./manifests/init.pp - WARNING: missing documentation for class parameter galera::gcomm_port on line 94
./manifests/init.pp - WARNING: missing documentation for class parameter galera::status_check on line 95
./manifests/init.pp - WARNING: missing documentation for class parameter galera::wsrep_sst_password on line 97
Error: Could not parse for environment production: This Array Expression has no effect. A value was produced and then forgotten (one or more preceding expressions may have the wrong form) at /home/jenkins/workspace/old.fuellib_review_syntax_check/deployment/puppet/galera/manifests/init.pp:347:16
FAILED checking ./manifests/init.pp, return code was 1
Checking /home/jenkins/workspace/old.fuellib_review_syntax_check/deployment/puppet/murano
Using puppet-lint
Error: Could not parse for environment production: The parameter 'public_port' is declared more than once in the parameter list at /home/jenkins/workspace/old.fuellib_review_syntax_check/deployment/puppet/murano/manifests/keystone/auth.pp:131:3
FAILED checking ./manifests/keystone/auth.pp, return code was 1
Checking /home/jenkins/workspace/old.fuellib_review_syntax_check/deployment/puppet/sahara
Using puppet-lint
Error: Could not parse for environment production: The parameter 'public_port' is declared more than once in the parameter list at /home/jenkins/workspace/old.fuellib_review_syntax_check/deployment/puppet/sahara/manifests/keystone/auth.pp:131:3
FAILED checking ./manifests/keystone/auth.pp, return code was 1
Example review: https://review.openstack.org/#/c/364432/
Example job: https://ci.fuel-infra.org/job/old.fuellib_review_syntax_check/331/consoleFull
Fix proposed to branch: stable/7.0
Review: https:/