rpl_end.inc/check-warnings.test/check-testcase.test etc do not wait for client disconnects to complete

[Laurynas Biveinis]

On 5.5 trunk, intermittently:

_StringException: Text attachment: traceback
------------

MTR's internal check of the test case 'rpl.rpl_innodb_bug28430' failed.
This means that the test case does not preserve the state that existed
before the test case was executed. Most likely the test case did not
do a proper clean-up. It could also be caused by the previous test run
by this thread, if the server wasn't restarted.
This is the diff of the states of the servers before and after the
test case was executed:
mysqltest: Logging to '/mnt/workspace/percona-server-5.5-trunk/BUILD_TYPE/release/Host/ubuntu-precise-64bit/mysql-test/var/3/tmp/check-mysqld_2.log'.
mysqltest: Results saved in '/mnt/workspace/percona-server-5.5-trunk/BUILD_TYPE/release/Host/ubuntu-precise-64bit/mysql-test/var/3/tmp/check-mysqld_2.result'.
mysqltest: Connecting to server localhost:13002 (socket /tmp/NdAeOq6L9k/3/mysqld.2.sock) as 'root', connection 'default', attempt 0 ...
mysqltest: ... Connected.
mysqltest: Start processing test commands from './include/check-testcase.test' ...
mysqltest: ... Done processing test commands.
--- /mnt/workspace/percona-server-5.5-trunk/BUILD_TYPE/release/Host/ubuntu-precise-64bit/mysql-test/var/3/tmp/check-mysqld_2.result 2016-08-31 17:20:35.773939000 +0300
+++ /mnt/workspace/percona-server-5.5-trunk/BUILD_TYPE/release/Host/ubuntu-precise-64bit/mysql-test/var/3/tmp/check-mysqld_2.reject 2016-08-31 17:20:37.653939000 +0300
@@ -1,5 +1,6 @@
 ID USER HOST DB COMMAND TIME STATE INFO TIME_MS ROWS_SENT ROWS_EXAMINED ROWS_READ
 <Id> root localhost NULL Query <Time> <State> SELECT * FROM INFORMATION_SCHEMA.PROCESSLIST WHERE COMMAND != 'Binlog Dump' X X X 1
+<Id> root localhost:60809 test Sleep <Time> <State> NULL X X X 1
 Slave_IO_State
 Master_Host 127.0.0.1
 Master_User root

mysqltest: Result content mismatch

not ok
safe_process[1224]: Child process: 1229, exit: 1

------------

[Laurynas Biveinis (laurynas-biveinis)]

Also on 5.5 trunk, intermittently:

MTR's internal check of the test case 'sys_vars.ssl_ca_basic' failed.
This means that the test case does not preserve the state that existed
before the test case was executed. Most likely the test case did not
do a proper clean-up. It could also be caused by the previous test run
by this thread, if the server wasn't restarted.
This is the diff of the states of the servers before and after the
test case was executed:
mysqltest: Logging to '/mnt/workspace/percona-server-5.5-trunk/BUILD_TYPE/debug/Host/ubuntu-trusty-64bit/mysql-test/var/3/tmp/check-mysqld_1.log'.
mysqltest: Results saved in '/mnt/workspace/percona-server-5.5-trunk/BUILD_TYPE/debug/Host/ubuntu-trusty-64bit/mysql-test/var/3/tmp/check-mysqld_1.result'.
mysqltest: Connecting to server localhost:13021 (socket /tmp/J_n2NlKKyO/3/mysqld.1.sock) as 'root', connection 'default', attempt 0 ...
mysqltest: ... Connected.
mysqltest: Start processing test commands from './include/check-testcase.test' ...
mysqltest: ... Done processing test commands.
--- /mnt/workspace/percona-server-5.5-trunk/BUILD_TYPE/debug/Host/ubuntu-trusty-64bit/mysql-test/var/3/tmp/check-mysqld_1.result 2016-08-31 17:29:31.735691272 +0300
+++ /mnt/workspace/percona-server-5.5-trunk/BUILD_TYPE/debug/Host/ubuntu-trusty-64bit/mysql-test/var/3/tmp/check-mysqld_1.reject 2016-08-31 17:29:31.880695383 +0300
@@ -1,5 +1,6 @@
 ID USER HOST DB COMMAND TIME STATE INFO TIME_MS ROWS_SENT ROWS_EXAMINED ROWS_READ
 <Id> root localhost NULL Query <Time> <State> SELECT * FROM INFORMATION_SCHEMA.PROCESSLIST WHERE COMMAND != 'Binlog Dump' X X X 1
+<Id> root localhost mtr Query <Time> <State> select @result = 0 X X X 1
 Slave_IO_State
 Master_Host 127.0.0.1
 Master_User root

mysqltest: Result content mismatch

not ok
safe_process[23566]: Child process: 23567, exit: 1

Here we have an overlap between testcase warnings checker and side effects checker.

[Laurynas Biveinis (laurynas-biveinis)]

     https://github.com/percona/percona-server/pull/973
     https://github.com/percona/percona-server/pull/974
     https://github.com/percona/percona-server/pull/975

[Laurynas Biveinis (laurynas-biveinis)]

This should also have fixed

perfschema.socket_instances_func w3 [ fail ]
        Test ended at 2016-08-27 05:55:30

CURRENT_TEST: perfschema.socket_instances_func
--- /mnt/workspace/percona-server-5.6-trunk/BUILD_TYPE/release/Host/centos7-64/mysql-test/suite/perfschema/r/socket_instances_func.result 2016-08-11 15:06:20.433715930 +0300
+++ /mnt/workspace/percona-server-5.6-trunk/BUILD_TYPE/release/Host/centos7-64/build/mysql-test/var/3/log/socket_instances_func.reject 2016-08-27 08:55:30.521552870 +0300
@@ -195,6 +195,7 @@
 EVENT_NAME IP
 wait/io/socket/sql/client_connection <LOCALHOST>
 wait/io/socket/sql/client_connection <LOCALHOST>
+wait/io/socket/sql/client_connection <LOCALHOST>
 wait/io/socket/sql/client_connection
 # Disconnect con1, con2 and con3
 # After waiting a bit we should have no differences to socket_instances

mysqltest: Result content mismatch

safe_process[9452]: Child process: 9453, exit: 1

Server [mysqld.1 - pid: 9304, winpid: 9304] log:
Server log from this test:
----------SERVER LOG START-----------
----------SERVER LOG END-------------

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-2191