os-net-config fails on 2nd run with DPDK net config

[Saravanan KR]

When os-net-config is called for the 2nd time during a compute node deployment with below nic config added to the compute.yaml, it fails with processutils.ProcessExecutionError saying that "ethtool" is not able to find the given interface.
            -
              type: ovs_user_bridge
              name: br-link
              members:
                -
                  type: ovs_dpdk_port
                  name: dpdk0
                  members:
                    -
                      type: interface
                      name: nic4

This is because if the interface is already bound to DPDK driver, ethtool will not be able to find the interface. On the first run, os-net-config configures it successfully and on the 2nd run, os-net-config throws exception.

And if the nic configs has nic numbering, with mixed interfaces, like DPDK and non-DPDK interfaces, if the non-DPDK interfaces are added after DPDK interfaces, like
nic1 - DPDK
nic2 - non-DPDK
then on the second run, DPDK nic will NOT be found, so the active nic list will change on the 2nd run.

[Saravanan KR (skramaja)]

Review posted - https://review.openstack.org/#/c/364354/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/370012

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/364354
Committed: https://git.openstack.org/cgit/openstack/os-net-config/commit/?id=c82cc955983065dba7b4d60858082150834ac356
Submitter: Jenkins
Branch: master

commit c82cc955983065dba7b4d60858082150834ac356
Author: Saravanan KR <email address hidden>
Date: Wed Aug 31 17:10:56 2016 +0530

    Fixed nic numbering issue of DPDK nics after the nic has bound

    * os-net-config is called multiple times during the deploy.
      Once the interface is bound to a driver, it will not be
      listed for ethtool to get the pci address, which will
      through exception. Handled this exception.
    * Stored the DPDK bound nic configs at '/var/lib/os-net-config/
      dpdk_mappings.yaml' file to emulate the same nic numbering
      after the nic has been bound to the DPDK driver.

    Partial-Bug: #1619330

    Change-Id: I6b1e45003f851f1fcf5b8730890c75331e8d0f8f

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/370012
Committed: https://git.openstack.org/cgit/openstack/os-net-config/commit/?id=e2c2f29fd171a688cc5bc6a73cdf7fec38aedd67
Submitter: Jenkins
Branch: master

commit e2c2f29fd171a688cc5bc6a73cdf7fec38aedd67
Author: Saravanan KR <email address hidden>
Date: Wed Sep 14 15:55:26 2016 +0530

    Add mac address to the DPDK mapping file

    When using mapping file with mac address, mapping logic will try
    to fetch the mac address of the interface, which will fail. Storing
    the mac address also in the DPDK mapping file so that we can satisfy
    mapping logic.

    Closes-Bug: #1619330

    Change-Id: I92ba7f589c8d848feb083f07c3f937b50aca388e

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-net-config 5.0.0.0rc2 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-net-config 5.0.0 release.