Codecheck rule "missing_space_after_access_type_symbol" conflicts with clang-format

[GunChleoc]

After running clang-format, the codecheck rule "missing_space_after_access_type_symbol" will be triggered for some files.

[GunChleoc (gunchleoc)]

This is becoming impractical, so I'm attaching the rule here and deleting it from the code base.

[Hans Joachim Desserud (hjd)]

Found this when looking for another codecheck-related issue and I have two questions. First off, is this the same as bug 1610731? It seems to be the same underlying issue, but I don't know the details.

Secondly, based on your comment, if the offending rule has been removed from the codebase, is this now considered fixed or was the intention to create a version of the rule which would coexist with clang-format?

[GunChleoc (gunchleoc)]

When we started using clang-format, we decided to jus drop some rules, and to attack some conflicting ones to bugs.

With some more experience under my belt, I am now in favor of dropping all conflicting codecheck rules that concern formatting only like this one.

They make Travis fail when the code doesn't conform, preventing us from merging. However, they will be automatically fixed by Bunnybot anyway during the merge because Bunnybot is runnng clang-format. So there is no need for them any more really.

if I can get a +1, I will mark all related bugs as invalid or won't fix.

[Hans Joachim Desserud (hjd)]

Sounds reasonable to me. Though since the conflict is resolved, one could also argue to mark them as fix committed, it just so happened it got solved by removing the codechecks. :)

[GunChleoc (gunchleoc)]

Good point - fix committed it is.

Fixed by automating clang-format.

[GunChleoc (gunchleoc)]

Fixed in build20-rc1