Registering a snap without agreeing to terms and conditions fails opaquely

[David Lawson]

If you attempt to register a snap name via "snap register foo" without first logging into the snapcraft site and agreeing to terms and conditions, setting a namespace, etc. If that's the case it should fail in a way that gives the user some indication of what they need to do to remedy the situation, not simply report "Registration failed".

[Fabián Ezequiel Gallina (fgallina)]

Local try-out against staging with snapcraft locally modified to print received response: https://pastebin.canonical.com/165288/

[Sergio Schvezov (sergiusens)]

A good error message would kindly tell the user what to do, don't you think?

[Fabián Ezequiel Gallina (fgallina)]

The same error string is widely used across endpoints and was re-used in register-name as a matter of consistency. Feel free to propose a string to globally enhance that message. Note there is also a similar message for missing agreement: https://bazaar.launchpad.net/~canonical-ca-hackers/software-center-agent/trunk/view/head:/src/devportal/api/handlers.py#L87

[Sergio Schvezov (sergiusens)]

I would prefer something like, "Account details are missing, please fill them in at https://blah"

[Evan (ev)]

We should catch both cases, not signed the developer agreement and missing a short namespace (to later be replaced with an SSO username check), on snapcraft login.

In the case of registration failed:
```
$ snapcraft login
Email:
Password:
Two-factor:

You need to sign the developer agreement to push snaps. Please visit http://… and log in again.
```

https://docs.google.com/document/u/1/d/1FCPYVcb01XqRoYXCTardWqF7y04Az9JkDPDu7YnvtTU/edit#heading=h.cx2d9tfvjapo

If the short namespace is missing:
```
$ snapcraft login
Email: <email address hidden>
Password:
Two-factor:

You need to set a username. It will appear in the developer field alongside the other details for your snap. Please visit http://… and log in again.
```

https://docs.google.com/document/d/1FCPYVcb01XqRoYXCTardWqF7y04Az9JkDPDu7YnvtTU/edit#heading=h.6xbdc5oax4o2

[Para Siva (psivaa)]

This is addressed via https://trello.com/c/Kt6qY5xV/521-developer-namespace-setting-pre-sso-usernames