[fuel-qa]Network settings are different before and after deploy

[Dmitry Belyaninov]

Detailed bug description:
There is failed SWARM test:
https://product-ci.infra.mirantis.net/job/9.x.system_test.ubuntu.command_line/44/testReport/(root)/cli_selected_nodes_deploy_huge/cli_selected_nodes_deploy_huge/

The reason is different network settings before and after deploy.

For example:
before
    "public_vrouter_vip": null,
    "management_vrouter_vip": null,
    "management_vip": null,
    "public_vip": null,
after
    management_vip: 10.109.11.12
    management_vrouter_vip: 10.109.11.11
    public_vip: 10.109.13.4
    public_vrouter_vip: 10.109.13.3

See attached files

Steps to reproduce:
 <put your information here>
Expected results:
Pass
Actual result:
Fail
Reproducibility:
 <put your information here>
Workaround:
 <put your information here>
Impact:
 <put your information here>
Description of the environment:
 Operation system: <put your information here>
 Versions of components: <put your information here>
 Reference architecture: <put your information here>
 Network model: <put your information here>
 Related projects installed: <put your information here>
Additional information:
 <put your information here>

[Roman Prykhodchenko (romcheg)]

IIRC VIPs are allocated during a deployment. Can someone please check this?

[Aleksey Kasatkin (alekseyk-ru)]

I can confirm that IPs (including VIPs) are allocated at the start of deployment (just before deployment serializer is called). Exception for VIPs is that VIP addresses can be set by user manually (via CLI) so they will not be changed during deployment.

[Aleksey Kasatkin (alekseyk-ru)]

But VIPs were not set manually according to the provided output. Thus, moving to invalid.

[Dmitry Belyaninov (dbelyaninov)]

The reason for difference is empty network settings after provosioning without deployment.

So we can:
- delete assert
- add some delay before get_networks call
- modify assert/files (to exclude unsetted params)

https://github.com/openstack/fuel-qa/blob/stable/mitaka/fuelweb_test/tests/test_cli.py#L210-L219
https://github.com/openstack/fuel-qa/blob/stable/mitaka/fuelweb_test/tests/test_cli.py#L639-L654

[Sergey Shevorakov (sshevorakov)]

swarm-fail -> swarm-blocker due to 4 cases affected: https://mirantis.testrail.com/index.php?/plans/view/20076

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/370247

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/370535

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/370535
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=d8be8cc6a14146183b4d5b966fc8f10e6f199439
Submitter: Jenkins
Branch: master

commit d8be8cc6a14146183b4d5b966fc8f10e6f199439
Author: Alexey Stepanov <email address hidden>
Date: Wed Sep 14 18:58:02 2016 +0300

    Do not check network configuration, when change is expected

    Do not check network configuration, when change is expected
    Network configuration check is valid only for scenarios with custom
    network configuration
    Dedicated test should be added
    Related-bug: #1618872

    Change-Id: I41bd0924972c1520cb5016c1eeefddb27d4c61b3

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/370247
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=9c6349fcb1e0a8a5a6050d66bd17749099c27087
Submitter: Jenkins
Branch: stable/mitaka

commit 9c6349fcb1e0a8a5a6050d66bd17749099c27087
Author: Alexey Stepanov <email address hidden>
Date: Wed Sep 14 18:58:02 2016 +0300

    Do not check network configuration, when change is expected

    Do not check network configuration, when change is expected
    Network configuration check is valid only for scenarios with custom
    network configuration
    Dedicated test should be added
    Related-bug: #1618872

    Change-Id: I41bd0924972c1520cb5016c1eeefddb27d4c61b3

[Aleksei Stepanov (penguinolog)]

Decided do not add additional tests -> fix commited. Custom test: PASS

[ElenaRossokhina (esolomina)]

new swarm failure: https://product-ci.infra.mirantis.net/job/9.x.system_test.ubuntu.command_line/62/testReport/(root)/cli_selected_nodes_deploy_huge/cli_selected_nodes_deploy_huge/
9.1 snapshot #268

[Dmitry Belyaninov (dbelyaninov)]

<<< 7. Deploy the controller node using Fuel CLI >>> PASS
<<< 8. Deploy the compute+cinder nodes using Fuel CLI >>> PASS
<<< 9. Compare network settings after compute deployment task >>> FAIL

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/372226

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/371441
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=7b677a1c1a2b5bac6927894c82aac032804a07a5
Submitter: Jenkins
Branch: stable/mitaka

commit 7b677a1c1a2b5bac6927894c82aac032804a07a5
Author: Alexey Stepanov <email address hidden>
Date: Fri Sep 16 13:44:47 2016 +0300

    Network configuration check: remove for autoconfig scenario

    Network configuration check: remove for autoconfig scenario
    Network settings, which was not set manually, is generated.
    Closes-bug: #1618872

    Change-Id: I23ef1db965cf419cb66e28a2f311f9ba6d8d0276

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/372226
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=7b813a7552f6451df3892546ff26c345f1fe3dad
Submitter: Jenkins
Branch: master

commit 7b813a7552f6451df3892546ff26c345f1fe3dad
Author: Alexey Stepanov <email address hidden>
Date: Fri Sep 16 13:44:47 2016 +0300

    Network configuration check: remove for autoconfig scenario

    Network configuration check: remove for autoconfig scenario
    Network settings, which was not set manually, are generated.
    Closes-bug: #1618872

    Change-Id: I23ef1db965cf419cb66e28a2f311f9ba6d8d0276

[Margarita Bliznikova (mbliznikova)]

Test was failed (#65 https://product-ci.infra.mirantis.net/job/9.x.system_test.ubuntu.command_line/65/testReport/(root)/cli_selected_nodes_deploy_huge/cli_selected_nodes_deploy_huge/)

[Margarita Bliznikova (mbliznikova)]

Log is in attachment.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/373370

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/373454

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/373454
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=d7e5521b34fd558b7e13f284e1f4025d75bfb008
Submitter: Jenkins
Branch: master

commit d7e5521b34fd558b7e13f284e1f4025d75bfb008
Author: Alexey Stepanov <email address hidden>
Date: Tue Sep 20 17:24:14 2016 +0300

    Wait for deployment start before read network settings

    Wait for deployment start before read network settings:
    Fuel 9.1 is async and result task start command is just task,
    which is not immediately started.
    Wait for task status: running
    TODO: implementation of custom network settings check

    Related-bug: #1618872

    Change-Id: I8a30e0afc97164dd1f61ae7607c8d440cc62b33f

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/373370
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=afe6c23e782f951e064c44fb5c0ddfb76ad26ac9
Submitter: Jenkins
Branch: stable/mitaka

commit afe6c23e782f951e064c44fb5c0ddfb76ad26ac9
Author: Alexey Stepanov <email address hidden>
Date: Tue Sep 20 17:24:14 2016 +0300

    Wait for deployment start before read network settings

    Wait for deployment start before read network settings:
    Fuel 9.1 is async and result task start command is just task,
    which is not immediately started.
    Wait for task status: running
    TODO: implementation of custom network settings check

    Related-bug: #1618872

    Change-Id: I8a30e0afc97164dd1f61ae7607c8d440cc62b33f

[Aleksei Stepanov (penguinolog)]

On the last SWARM failure due to:

[root@nailgun ~]# fuel2 task network-configuration download 7
Network configuration for task with id=7 downloaded to /root/network_configuration_7.yaml
[root@nailgun ~]# cat /root/network_configuration_7.yaml
null
...

This is not QA side bug.

[Aleksei Stepanov (penguinolog)]

QA side fixed, product side broken