test_update_port_status_notify_port_event_after_update fails

[Isaku Yamahata]

test_update_port_status_notify_port_event_after_update fails to break gate job

https://review.openstack.org/#/c/357458/
The change set of 25f5912cf8f69f18d111bd60a6cc6ee488755ff3
change id of Iedad1ccae45005efaaa74d5571df04197757d07a
introduced a test test_update_port_status_notify_port_event_after_update
that is valid only when l3 plugin support l3-ha.

The test shouldn't run when l3-ha isn't supported.

[Isaku Yamahata (yamahata)]

The bug is in neutron side.

[Assaf Muller (amuller)]

It's a unit test in Neutron code, if you're running it in the ODL repo can't you simply skip it?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/363175

[Isaku Yamahata (yamahata)]

The issue would apply to any l3 plugin without l3-ha.
So the unit test should be fixed in order to prevent further (unreported?) breakage.

[Assaf Muller (amuller)]

It's a unit test, not an API test. The unit testing framework does the setup.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/363175
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=03c412ff011a8d4e86afbada24db675028861728
Submitter: Jenkins
Branch: master

commit 03c412ff011a8d4e86afbada24db675028861728
Author: Isaku Yamahata <email address hidden>
Date: Tue Aug 30 12:21:25 2016 -0700

    split out l3-ha specific test from TestMl2PortsV2

    split out test_update_port_status_notify_port_event_after_update
    from ml2.test_plugin.TestMl2PortsV2 into TestMl2PortsV2WithL3

    The change set of 25f5912cf8f69f18d111bd60a6cc6ee488755ff3
    change id of Iedad1ccae45005efaaa74d5571df04197757d07a
    introduced a test,
    test_update_port_status_notify_port_event_after_update, that is valid
    only when l3 plugin support l3-ha. Such assumption isn't always true
    depending on actual ml2 driver.
    Since test cases in ml2.test_plugin is used as a common base for
    multiple drivers,
    test_update_port_status_notify_port_event_after_update, may or may not
    pass. So split out tests with very specific assumption into a new
    dedicated testcase so that each driver can safely reuse tests in
    tests/unit/plugin/ml2 based on their characteristics.

    Closes-Bug: #1618601
    Change-Id: Ie81dde976649111d029a7d107c99960aded64915

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 9.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/385395

[OpenStack Infra (hudson-openstack)]

Change abandoned by venkata anil (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/385395
Reason: in favor of https://review.openstack.org/#/c/364407/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/364407
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5860fb21e966ab8f1e011654dd477d7af35f7a27
Submitter: Jenkins
Branch: stable/mitaka

commit 5860fb21e966ab8f1e011654dd477d7af35f7a27
Author: venkata anil <email address hidden>
Date: Wed Oct 12 10:57:46 2016 +0000

    Check for ha port to become ACTIVE

    After reboot(restart of l3 and l2 agents) of the node routers
    can be processed by l3 agent before openvswitch agent sets up
    appropriate ha ports. This change add notification for l3 agent
    that ha port becomes ACTIVE and keepalived can be enabled.

    note: Release notes added to specify l3 agent dependency on neutron
    server.

    Closes-bug: #1597461

    Co-Authored-By: venkata anil <email address hidden>

    (cherry picked from commit 25f5912cf8f69f18d111bd60a6cc6ee488755ff3)

    Conflicts:
            neutron/db/l3_hascheduler_db.py
            neutron/services/l3_router/l3_router_plugin.py
            neutron/tests/unit/plugins/ml2/test_plugin.py
            neutron/tests/functional/agent/l3/test_ha_router.py
            releasenotes/notes/l3ha-agent-server-dependency-1fcb775328ac4502.yaml

    Change-Id: Iedad1ccae45005efaaa74d5571df04197757d07a
    (cherry picked from commit 4ad841c4cf1b23695a792ea6facf1dbf66cb48e9)

    split out l3-ha specific test from TestMl2PortsV2

    split out test_update_port_status_notify_port_event_after_update
    from ml2.test_plugin.TestMl2PortsV2 into TestMl2PortsV2WithL3

    The change set of 25f5912cf8f69f18d111bd60a6cc6ee488755ff3
    change id of Iedad1ccae45005efaaa74d5571df04197757d07a
    introduced a test,
    test_update_port_status_notify_port_event_after_update, that is valid
    only when l3 plugin support l3-ha. Such assumption isn't always true
    depending on actual ml2 driver.
    Since test cases in ml2.test_plugin is used as a common base for
    multiple drivers,
    test_update_port_status_notify_port_event_after_update, may or may not
    pass. So split out tests with very specific assumption into a new
    dedicated testcase so that each driver can safely reuse tests in
    tests/unit/plugin/ml2 based on their characteristics.

    Conflicts:
            neutron/tests/unit/plugins/ml2/test_plugin.py

    Closes-Bug: #1618601
    Change-Id: Ie81dde976649111d029a7d107c99960aded64915
    (cherry picked from commit 03c412ff011a8d4e86afbada24db675028861728)

    Change-Id: Iedad1ccae45005efaaa74d5571df04197757d07a
    (cherry picked from commit 4ad841c4cf1b23695a792ea6facf1dbf66cb48e9)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 8.4.0 release.