octane restart instances during the preupgrade-compute command execution

[Ilya Kharin]

Octane restart instances on Compute nodes during the preupgrade-compute command.

Steps to reproduce:
 1. Install 7.0 environment with
        3xControllers nodes
        3xCeph-OSD nodes
        3xCompute nodes
 2. Upgrade the Fuel Master node to 8.0, then to 9.0
 3. Create an upgrade release
        <release_id> = fuel2 release clone <release_id>
 4. Create an upgrade environment
        octane upgrade-env <orig_env_id> <release_id>
 5. Perform an upgrade of the first controller
        octane upgrade-node --isolated <new_env_id> <controller_node_id>
 6. Perform an upgrade of OpenStack DB
        octane upgrade-db <orig_env_id> <new_env_id>
 7. Perform an upgrade of Ceph-Mon
        octane upgrade-ceph <orig_env_id> <new_env_id>
 8. Perform switch of OpenStack Control plane
        octane upgrade-controlplane <orig_env_id> <new_env_id>
 9. Perform a pre-upgrade of Compute nodes to the Liberty release
        octane preupgrade-compute <liberty_release_id> <node_id>

Expected results:
 The specified compute nodes are successfully pre-upgraded, nova-compute and neutron-ovs-agent are the appropriate Liberty version, services are restored and can communicate with the OpenStack Control Plane node.

Actual result:
 Instances during the pre-upgrade are restarted.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/362961

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/362961
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=10409edb220584c921ae857032da22b0b3f1c615
Submitter: Jenkins
Branch: master

commit 10409edb220584c921ae857032da22b0b3f1c615
Author: Ilya Kharin <email address hidden>
Date: Tue Aug 30 18:15:42 2016 +0300

    Do not upgrade libvirt packages to 8.0

    Libvirt packages have not to be upgraded to the version that is shipped
    by the 8.0 release.

    Change-Id: I4ebd9722cdfd02476ba743c2a713baf5efed704b
    Partial-Bug: #1618517

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/365042

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/365042
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=378a8d70a57f5ad91a74c844e170cc5a62e02441
Submitter: Jenkins
Branch: stable/mitaka

commit c95b137224601631ea6cc87e78a9f2a9fae5e937
Author: Ilya Kharin <email address hidden>
Date: Fri Sep 2 17:34:50 2016 +0300

    Return removed CEPH_UPSTART_VERSION constant

    Change-Id: I89ca8bfb76fd5af1bd44017104e8f1fa73240db9
    Related-Bug: #1619311

commit a54ab589635b9b1a5368c455078570e3d0cce2f2
Author: Ilya Kharin <email address hidden>
Date: Fri Sep 2 00:51:22 2016 +0300

    Unit tests and fixes for nova_migrate_flavor_data

    Some unit test cases were wrote alongside with some fixes

    Change-Id: Ie4d23a4238beb6c9d42637bb16fc1a55c10993a4
    Related-Bug: #1619311

commit 243a2ce5b6e8b473011c280ed1b691e3af7efc5b
Author: Ilya Kharin <email address hidden>
Date: Thu Sep 1 17:53:57 2016 +0300

    Perform flavor data migrations only for 7.0 envs

    The next command performs data migrations for flavors:

      nova-manage db migrate_flavor_data

    This migration have to be executed only on environments with the Kilo
    version.

    Change-Id: Ic65c4b1bc96ca69e8b74dd1a969953ac4283578d
    Closes-Bug: #1619311

commit 10409edb220584c921ae857032da22b0b3f1c615
Author: Ilya Kharin <email address hidden>
Date: Tue Aug 30 18:15:42 2016 +0300

    Do not upgrade libvirt packages to 8.0

    Libvirt packages have not to be upgraded to the version that is shipped
    by the 8.0 release.

    Change-Id: I4ebd9722cdfd02476ba743c2a713baf5efed704b
    Partial-Bug: #1618517

commit f717784237e14d3deaa687e563a0a11068f2a3bc
Author: Sergey Abramov <email address hidden>
Date: Tue Aug 30 14:27:56 2016 +0300

    Add validation on upgrade node in isolation

    required for fix problem with update first
    controller without isolation

    Change-Id: Ie3a07eb12ad306b6bdfc7f91d5ec922e19d48017

commit 5989919ed2f11fcd3aa2a5342a8f2487c28eb855
Author: Vladimir Khlyunev <email address hidden>
Date: Tue Aug 30 13:58:24 2016 +0300

    Upload net template to seed env while cloning

    Right now there is a typo in network template uploading code
    which leads to uploading of template to existing cluster but expected
    behavior is uploading to new cluster.

    Change-Id: I2c52921e367216bcdf39682a43a2b0940e4cb8c3
    Closes-bug:1618408

commit 1c5952ec88ddaf57d41f67eb4424f7fbbd4229df
Author: Sergey Ryabin <email address hidden>
Date: Tue Aug 30 14:08:37 2016 +0300

    Fix for mysql usage with non-root access

    Change-Id: Ieae0f86bacadf074200e3b0e2e0c4c21d6778bc2
    Closes-Bug: #1606504

commit 7aadd4265ec3401e7d883f5b01a1870ea5b750ca
Author: Pavel Chechetin <email address hidden>
Date: Tue Aug 30 14:27:48 2016 +0300

    Resolve all current Puppet lint warnings

    Change-Id: I8d1e486fdb25a8d7cf52fdec7b36f7acfa38cbab

commit f9f18276ddf6738f2fab64c3c609d68e30889706
Author: Pavel Chechetin <email address hidden>
Date: Tue Aug 30 14:21:16 2016 +0300

    Start testing Puppet related code by CI

    Change-Id: I12aa288f4613b69d332e448c3a50f0c36de139ea

commit...

[Alexander Kurenyshev (akurenyshev)]

This bug currently couldn't be verified due to compute nodes pre-upgrades

[Vladimir Khlyunev (vkhlyunev)]

root@node-1:~# ssh cirros@10.109.18.129
cirros@10.109.18.129's password:
$ uptime
 18:39:39 up 5:21, 1 users, load average: 0.00, 0.01, 0.03
$ Connection to 10.109.18.129 closed.