SM Monitoring: Disk stats not processed correctly, display error if some server in full list doesn't have monitoring stats

[Nitish Krishna Kaveri]

The bug:
Machine 1:
Last login: Mon Aug 29 12:22:28 2016 from puppet
root@sdkvse2:~# iostat -m
Linux 3.13.0-85-generic (sdkvse2) 08/29/2016 x86_64 (16 CPU)

avg-cpu: %user %nice %system %iowait %steal %idle
           8.00 0.13 4.49 0.49 0.00 86.89

Device: tps MB_read/s MB_wrtn/s MB_read MB_wrtn
sda 0.00 0.00 0.00 1 0
sdb 21.18 0.02 0.61 10008 308699
dm-0 45.42 0.02 0.61 9963 308699
dm-1 0.00 0.00 0.00 1 0

Machine 2:
root@server12:~# iostat -m
Linux 3.13.0-85-generic (server12) 08/29/2016 x86_64 (4 CPU)

avg-cpu: %user %nice %system %iowait %steal %idle
           5.81 0.00 1.31 0.19 0.00 92.70

Device: tps MB_read/s MB_wrtn/s MB_read MB_wrtn
sda 64.45 0.46 1.17 1659 4248
dm-0 120.38 0.45 1.17 1623 4248
dm-1 0.28 0.00 0.00 4 0

In Machine 1 (sdkvse2) issue is seen because the line:
Linux 3.13.0-85-generic (sdkvse2) 08/29/2016 x86_64 (16 CPU)
Contains “sd” like the disks listed
But line:
Linux 3.13.0-85-generic (server12) 08/29/2016 x86_64 (4 CPU) doesn’t contain sd or dm

The code has a check:
if line.find('sd') != -1 or line.find('dm') != -1:
Only if this is true it will process the line
It is processing the linux line wrongly on Machine 1 (shouldn’t process that line)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/23712
Submitter: Nitish Krishna Kaveri (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/23713
Submitter: Nitish Krishna Kaveri (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/23712
Committed: http://github.org/Juniper/contrail-server-manager/commit/9e13811650f5dc15990a19bde0e01f04685475fa
Submitter: Zuul
Branch: master

commit 9e13811650f5dc15990a19bde0e01f04685475fa
Author: nitishkrishna <email address hidden>
Date: Mon Aug 29 16:14:29 2016 -0700

Closes-Bug: #1618249 - SM Monitoring has some bugs in show, processing

If some server is not there in the full list, show all monitoring info fails.
Also for some servers, the disk processing fails due to wrong if condition

Change-Id: I2f024bb7fe6ca3032f8c4241e86367a7790c4dc1

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/23713
Committed: http://github.org/Juniper/contrail-server-manager/commit/4e04910778d913a71fa6fe03e6dd80b6ecec8840
Submitter: Zuul
Branch: R3.1

commit 4e04910778d913a71fa6fe03e6dd80b6ecec8840
Author: nitishkrishna <email address hidden>
Date: Mon Aug 29 16:14:29 2016 -0700

Closes-Bug: #1618249 - SM Monitoring has some bugs in show, processing

If some server is not there in the full list, show all monitoring info fails.
Also for some servers, the disk processing fails due to wrong if condition

Change-Id: I2f024bb7fe6ca3032f8c4241e86367a7790c4dc1