Acq Wishlist: Use 13 digit ISBN by default

[Christine Burns]

Acquisitions

EG 2.10

When using Load MARC Order Records interface to create purchase order or selection list.
Line items shows 10 digit ISBN in order identifier field( I believe it just uses the first 020 field listed in the MARC record)

While it is possible to choose the 13 digit ISBN from order identifier drop down list -> we would like the system to choose the 13 digit ISBN by default.

[Tiffany Little (tslittle)]

Still an issue in 3.10. Lately I've had an increasing number of vendors say that they can only accept ISBN-13, so this is becoming more of a problem for us.

[Tiffany Little (tslittle)]

Here's a patch for testing: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=2a6d22aa6561a84b3df029dbfb960e434ac3dff6

[Christine Morgan (cmorgan-z)]

Testing on Tiffany's test server in an incognito window:

- Adding a line item to a purchase order manually: I added a UPC to an existing bib record for testing. The identifier of UPC was selected properly in the preview screen after clicking View/Place Orders. Once added to the purchase order, however, the identifier in the line item switched to ISBN and the value in the box just had the "Order Identifier..." text.

- Creating a PO from a file uploaded through the Load MARC Order Records interface: The file I uploaded had one record with a 13 digit ISBN, one record with both a 13 digit and a 10 digit ISBN with the 10 digit listed first in the bib, and a record with a UPC. The 13 digit ISBNs were correctly selected in the two line items that were created. For the record with the UPC the ISBN identifier was selected and the box for the value just had the "Order Identifier..." text. I uploaded this same file on a 3.9 test system and the UPC was correctly selected for that line item.

[Mike Rylander (mrylander)]

I scanned the proposed patch and wonder if it would make sense to simply sort the attributes by length, longest-first, instead of filtering them in a different way? Something like:

my ($attr) = sort { length($a->attr_value) > length($b->attr_value) ? -1 : 1 } grep {$_->attr_name eq 'isbn'} @{$li->attributes};