InterfaceAttachFailed: Failed to attach network adapter device

[Armando Migliaccio]

This looks it shows in the gate on a master branch change:

http://logs.openstack.org/04/353704/9/gate/gate-tempest-dsvm-neutron-linuxbridge/e6ca9f3/console.html#_2016-08-26_19_50_16_384253

http://logs.openstack.org/04/353704/9/gate/gate-tempest-dsvm-neutron-linuxbridge/e6ca9f3/logs/screen-n-cpu.txt.gz?level=TRACE#_2016-08-26_19_36_06_377

http://paste.openstack.org/show/564060/

The root cause:

2016-08-26 19:36:06.377 24801 ERROR os_vif Stderr: u"device brqd7d244e3-06 already exists; can't create bridge with the same name\n"

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/361516

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/361526

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/361526
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ab61970644086de392f12d6d6a054ca85fb6e5d7
Submitter: Jenkins
Branch: master

commit ab61970644086de392f12d6d6a054ca85fb6e5d7
Author: Kevin Benton <email address hidden>
Date: Fri Aug 26 16:36:20 2016 -0700

    Make addbr safe to bridge add races

    This makes the code that constructs a bridge safe to concurrent
    additions of the same bridge.

    Change-Id: I3c85731de6b6d07af54ace5f8d835f01a366f5b3
    Closes-Bug: #1617447

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/361516
Committed: https://git.openstack.org/cgit/openstack/os-vif/commit/?id=c25ce5a852d97f8159e77cb7ed71df31c482ce76
Submitter: Jenkins
Branch: master

commit c25ce5a852d97f8159e77cb7ed71df31c482ce76
Author: Kevin Benton <email address hidden>
Date: Fri Aug 26 15:56:24 2016 -0700

    Check for concurrent bridge creation in bridge add

    With Linux bridge, either Neutron or Nova may create the bridge
    associated with a network so this process must be robust to
    concurrent creations of the same bridge.

    This change just has the addbr call capture exceptions and avoid
    reraising if the device already exists.

    Closes-Bug: #1617447
    Change-Id: Ib0266086e0caffecf3f9f2a8291369cfa155f386

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/363975

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 9.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/363975
Committed: https://git.openstack.org/cgit/openstack/os-vif/commit/?id=ac8c8376249fde6a226f57c49c370d197602fb6a
Submitter: Jenkins
Branch: stable/newton

commit ac8c8376249fde6a226f57c49c370d197602fb6a
Author: Kevin Benton <email address hidden>
Date: Fri Aug 26 15:56:24 2016 -0700

    Check for concurrent bridge creation in bridge add

    With Linux bridge, either Neutron or Nova may create the bridge
    associated with a network so this process must be robust to
    concurrent creations of the same bridge.

    This change just has the addbr call capture exceptions and avoid
    reraising if the device already exists.

    Closes-Bug: #1617447
    Change-Id: Ib0266086e0caffecf3f9f2a8291369cfa155f386
    (cherry picked from commit c25ce5a852d97f8159e77cb7ed71df31c482ce76)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-vif 1.2.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-vif 1.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-vif 1.2.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-vif 1.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-vif 1.2.1 release.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/438557

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/438557
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1feb19c83ff61a3782ce862d71b8d04e21d7aa00
Submitter: Jenkins
Branch: master

commit 1feb19c83ff61a3782ce862d71b8d04e21d7aa00
Author: Kevin Benton <email address hidden>
Date: Mon Feb 27 07:23:46 2017 -0800

    Stop skipping compute owner in Linux Bridge loop

    Nova Ocata and Newton have protection against bridge
    creation races in os-vif[1] so we no longer need
    to special-case this port type in the Linux Bridge
    loop going forward in Pike.

    1. Ib0266086e0caffecf3f9f2a8291369cfa155f386

    Related-Bug: #1617447
    Change-Id: I2a23d0cbc4c4d0db6e9f48d91ca03b5007f91a84

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/447150
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1b987be2b55558dcc276fcfc8af6e39f8b6bac16
Submitter: Jenkins
Branch: master

commit 1b987be2b55558dcc276fcfc8af6e39f8b6bac16
Author: Kevin Benton <email address hidden>
Date: Fri Mar 17 14:56:36 2017 -0700

    Use vif_type='tap' for LinuxBridge for consistency

    This adjusts the Linux Bridge mechanism driver to return
    the 'tap' VIF type to Nova so the Linux Bridge agent is
    responsible for plugging all ports into bridges.

    This completely eliminates all of the work Nova was doing with
    regard to bridges so we now have one consistent path how ports
    (both compute and dhcp/l3) are connected into Linux Bridge
    networks. Both Nova and the DHCP/L3 agents will now just create
    a device and leave wiring to bridges to be completely the
    responsibility of the L2 agent.

    In order to preserve backwards compatibiliy with Ocata agents
    that won't touch compute ports, we only report back vif_type='tap'
    if the agent has a report_state value showing that it wires compute
    ports.

    This will also solve a longstanding bug (bug #1105488) that
    is preventing Nova instances from using custom bridge mappings
    since the agent will be guaranteed to be responsible for the
    connection to the bridge.

    Depends-On: I075595158d8f3b5a6811c4794aa7b91912940db5

    Related-Bug: #1617447
    Closes-Bug: #1673910
    Closes-Bug: #1105488
    Change-Id: I23c5faaeab69aede1fd038a36f4a0b8f928498ce

[Ihar Hrachyshka (ihar-hrachyshka)]

All backports till Newton completed.