Searchlight UI displaying saved search for other users

[Travis Tripp]

Searchlight UI persists previous search on the local browser. If I log in as admin, put in a search query, log out, and come back in as "demo", I see the admin's last query. This is only on the same local browser.

A few options to consider:

1) Don't save query except in the service. This does mean that navigating out to any other django page and back will lose the query. Maybe not a problem.

2) Set / get with a user id in the key name.
  https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/openstack-service-api/user-session.service.js

https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/rest/keystone.py#L546-L559

3) See if we can add a hook at login time to clear the last query (still not totally secure).

[OpenStack Infra (hudson-openstack)]

Change abandoned by Travis Tripp (<email address hidden>) on branch: master
Review: https://review.openstack.org/370837
Reason: Done by https://review.openstack.org/#/c/371783/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/371783
Committed: https://git.openstack.org/cgit/openstack/searchlight-ui/commit/?id=a7e91d203fd8844bd96764f3be88d6e242609d02
Submitter: Jenkins
Branch: master

commit a7e91d203fd8844bd96764f3be88d6e242609d02
Author: Matt Borland <email address hidden>
Date: Fri Sep 16 13:53:27 2016 -0600

    Save SL-UI settings separated by user

    This patch uses the domain/username as part of the key for local storage. NOTE:
    this does not mean that the data is not available to the other users, however,
    it is a good feature that allows different logged-in users to maintain different
    settings. This is also useful for an operator who uses different users to perform
    different activities (monitoring, etc.).

    Change-Id: Iab0ca354b72d6d70701e4f33cd7b0ff56ed9a94c
    Closes-Bug: 1617369

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/searchlight-ui 1.0.0.0rc1 release candidate.