Nailgun returns incorrect node status

[Bulat Gaifullin]

Nailgun reports error status for node even in database the status of node is not error.
the main reason is that error status is detected by 'error_type', but not all functions reset this field after error was resolved.
According to graph-concept-extension the error status detecting algorithm should be reworked, but until the change which introduced this bug should be reverted: https://review.openstack.org/#/c/356401/

the incorrect status handling affected graph execution.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/360958

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/362902

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/360958
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=4f49abcaf56e41dedae883b92c752ecac89d6c8d
Submitter: Jenkins
Branch: master

commit 4f49abcaf56e41dedae883b92c752ecac89d6c8d
Author: Bulat Gaifullin <email address hidden>
Date: Fri Aug 26 10:55:40 2016 +0300

    Reset error_type if problem with ip was resolved

    Also revert detecting error status by error_type,
    because there is no gurarantee that error_type is reseted
    in all places. need to prepare proper fix for error_type

    Change-Id: I6de0b99eced36fa011f1fb45cf56c895b9fa3372
    Closes-bug: 1617193

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/362902
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=185a5b8681d35fe29b8c8045bd1444fe07cfb0c2
Submitter: Jenkins
Branch: stable/mitaka

commit 185a5b8681d35fe29b8c8045bd1444fe07cfb0c2
Author: Bulat Gaifullin <email address hidden>
Date: Fri Aug 26 10:55:40 2016 +0300

    Reset error_type if problem with ip was resolved

    Also revert detecting error status by error_type,
    because there is no gurarantee that error_type is reseted
    in all places. need to prepare proper fix for error_type

    Change-Id: I6de0b99eced36fa011f1fb45cf56c895b9fa3372
    Closes-bug: 1617193

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-web 10.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-web 10.0.0 release.