form exception on host aggregate create

Bug #1617140 reported by shlo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
shlo

Bug Description

The expected error message about missing the required "name" field on the create-aggregate form is shown as expected only in the case that there were no existing aggregates in the system.
Under the circumstance that there are existing aggregates, workflow exception raises when create button is clicked without the required "name" field filled.

shlo (shlo-sam)
Changed in horizon:
assignee: nobody → shlo0828 (shlo-sam)
status: New → In Progress
shlo (shlo-sam)
description: updated
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/364049

Changed in horizon:
importance: Undecided → High
milestone: none → newton-rc1
Revision history for this message
surbhi sarda (surbhisarda) wrote :

can i work on this bug?

Revision history for this message
shlo (shlo-sam) wrote :

I have committed a fix proposed on https://review.openstack.org/364049
Could you help to review it?

Changed in horizon:
milestone: newton-rc1 → next
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/364049
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=eedac01a9c529868b5d9be1294d8ea0a955614e2
Submitter: Jenkins
Branch: master

commit eedac01a9c529868b5d9be1294d8ea0a955614e2
Author: shlo <email address hidden>
Date: Thu Sep 1 11:27:49 2016 +0800

    fix workflow exception on host aggregate create form

    Under the circumstance that there are existing aggregates, this bug
    happens when create button is clicked without the required "name" field
    filled. Error toast shows instead of the expected error message on the
    create form.
    When the form posts without name filed filled, the name attribute in the
    clean data is None instead of an empty string, which causes
    AttributeError on the following string operation.

    1. patch an empty string as the fallback value for the 'name' variable
    2. corresponding unit test is attached

    Change-Id: I0bdf469d87aa06ab58b73e6ce41bdf63bb36a538
    Closes-Bug: #1617140

Changed in horizon:
status: In Progress → Fix Released
Changed in horizon:
milestone: next → pike-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 12.0.0.0b1

This issue was fixed in the openstack/horizon 12.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.