[MIR] zmqpp

[Łukasz Zemczak]

[Availability]
 * Available in universe.

[Rationale]
 * This package is required by unity-scopes-api.

[Security]
 * No known security issues at this time, it has been in active use on our touch devices since a very long time already.

[Quality assurance]
 * This package comes with a set of unit tests that are all being run during build-time.

[Dependencies]
 Most dependencies are already in main, with only a small nitpick:
 * libboost-test-dev is in universe, but its source boost-defaults is already in main.
 * zeromq3 has a MIR filled as well (https://bugs.launchpad.net/ubuntu/+source/zeromq3/+bug/1597439)

[Maintenance]
 * This package is used by Canonical upstream projects so the packaging is maintained by Canonical. The upstream code is actively maintained and developed by the zeromq team.

[Łukasz Zemczak (sil2100)]

Please note that we have a new version of zmqpp staged for release (we were waiting for an FFe earlier): https://bugs.launchpad.net/ubuntu/+source/zeromq3/+bug/1612240

[Seth Arnold (seth-arnold)]

Please upload a new zmqpp soon; 3.2.0-0ubuntu4 fails to build from source for me. I fixed the first mistake with this patch:

--- a/src/tests/test_socket.cpp
+++ b/src/tests/test_socket.cpp
@@ -45,7 +45,7 @@
 BOOST_AUTO_TEST_CASE( socket_creation_bad_type )
 {
  zmqpp::context context;
- BOOST_CHECK_THROW(zmqpp::socket socket(context, static_cast<zmqpp::socket_type>(-1)), zmqpp::zmq_internal_exception)
+ BOOST_CHECK_THROW(zmqpp::socket socket(context, static_cast<zmqpp::socket_type>(-1)), zmqpp::zmq_internal_exception);
 }

 BOOST_AUTO_TEST_CASE( valid_socket )

But this was not sufficient and I don't know how to fix this:

g++ -MMD -std=c++0x -pipe -Wall -fPIC -DBUILD_ENV=max -DBUILD_VERSION='"3.2.0"' -DBUILD_VERSION_MAJOR=3 -DBUILD_VERSION_MINOR=2 -DBUILD_VERSION_REVISION=0 -DBUILD_DATESTAMP='"2016-09-22 17:05"' -DBUILD_LIBRARY_NAME='"zmqpp"' -DBUILD_CLIENT_NAME='"zmqpp"' -I./src -O3 -funroll-loops -ffast-math -finline-functions -fomit-frame-pointer -DNDEBUG -c -o build/max-g++/obj/tests/test_socket_options.o src/tests/test_socket_options.cpp
src/tests/test_socket_options.cpp: In function ‘void socket_options::try_set(zmqpp::socket&, const zmqpp::socket_option&, const CheckType&, const string&, const string&)’:
src/tests/test_socket_options.cpp:26:37: error: no match for ‘operator<<’ (operand types are ‘const char [16]’ and ‘const string {aka const std::__cxx11::basic_string<char>}’)
  BOOST_CHECKPOINT("setting option " << option_name << " against set type '" << value_type << "'");
                   ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
In file included from /usr/include/boost/config/no_tr1/complex.hpp:21:0,
                 from /usr/include/boost/math/special_functions/math_fwd.hpp:31,
                 from /usr/include/boost/math/special_functions/sign.hpp:17,
                 from /usr/include/boost/lexical_cast/detail/inf_nan.hpp:34,
                 from /usr/include/boost/lexical_cast/detail/converter_lexical_streams.hpp:63,
                 from /usr/include/boost/lexical_cast/detail/converter_lexical.hpp:54,
                 from /usr/include/boost/lexical_cast/try_lexical_convert.hpp:42,
                 from /usr/include/boost/lexical_cast.hpp:32,
                 from src/tests/test_socket_options.cpp:7:
/usr/include/c++/6/complex:526:5: note: candidate: template<class _Tp, class _CharT, class _Traits> std::basic_ostream<_CharT, _Traits>& std::operator<<(std::basic_ostream<_CharT, _Traits>&, const std::complex<_Tp>&)
     operator<<(basic_ostream<_CharT, _Traits>& __os, const complex<_Tp>& __x)
     ^~~~~~~~
/usr/include/c++/6/complex:526:5: note: template argument deduction/substitution failed:
src/tests/test_socket_options.cpp:26:40: note: mismatched types ‘std::basic_ostream<_CharT, _Traits>’ and ‘const char [16]’
  BOOST_CHECKPOINT("setting option " << option_name << " against set type '" << value_type << "'");
                                        ^~~~~~~~~~~
In file included from /usr/include/c++/6/memory:82:0,
                 from /usr/include/boost/config/no_tr1/memory.hpp:21,
                 from /usr/include/boost/smart_ptr/shared_ptr.hpp:23,
                 from /usr/include/boost/shared_ptr.hpp:17,
        ...

[Łukasz Zemczak (sil2100)]

Thanks for taking a look! The new zmqpp is staged for release today as soon as one unity-scopes-api silo gets out of the QA queue.

[Łukasz Zemczak (sil2100)]

The new zmqpp is in the UNAPPROVED queue as of Friday the 23rd. Hopefully it'll go to -proposed once Final Beta is dealt with.

[Łukasz Zemczak (sil2100)]

As noted already, but zmqpp is now in the yakkety release pocket, ready for review.

[Steve Langasek (vorlon)]

Pre-promoting per discussion with management, to unblock building of images with unity8 enabled so these get some burn-in before release.

Override component to main
zmqpp 4.1.2-0ubuntu1 in yakkety: universe/libs -> main
libzmqpp-dev 4.1.2-0ubuntu1 in yakkety amd64: universe/libdevel/optional/100% -> main
libzmqpp-dev 4.1.2-0ubuntu1 in yakkety arm64: universe/libdevel/optional/100% -> main
libzmqpp-dev 4.1.2-0ubuntu1 in yakkety armhf: universe/libdevel/optional/100% -> main
libzmqpp-dev 4.1.2-0ubuntu1 in yakkety i386: universe/libdevel/optional/100% -> main
libzmqpp-dev 4.1.2-0ubuntu1 in yakkety powerpc: universe/libdevel/optional/100% -> main
libzmqpp-dev 4.1.2-0ubuntu1 in yakkety ppc64el: universe/libdevel/optional/100% -> main
libzmqpp-dev 4.1.2-0ubuntu1 in yakkety s390x: universe/libdevel/optional/100% -> main
libzmqpp4 4.1.2-0ubuntu1 in yakkety amd64: universe/libs/optional/100% -> main
libzmqpp4 4.1.2-0ubuntu1 in yakkety arm64: universe/libs/optional/100% -> main
libzmqpp4 4.1.2-0ubuntu1 in yakkety armhf: universe/libs/optional/100% -> main
libzmqpp4 4.1.2-0ubuntu1 in yakkety i386: universe/libs/optional/100% -> main
libzmqpp4 4.1.2-0ubuntu1 in yakkety powerpc: universe/libs/optional/100% -> main
libzmqpp4 4.1.2-0ubuntu1 in yakkety ppc64el: universe/libs/optional/100% -> main
libzmqpp4 4.1.2-0ubuntu1 in yakkety s390x: universe/libs/optional/100% -> main
15 publications overridden.

[Seth Arnold (seth-arnold)]

My apologies for letting this slip.

Considering this came from the zmq project and wouldn't have been surprising if it had been included in the zeromq3 source package, I decided to just give this very quick spot-checks and review the packaging as a sanity check.

Security team ACK for promoting zmqpp to main.

Thanks

[Michael Terry (mterry)]

- This needs a team bug subscriber for whichever team is looking after this. ~unity-api-team?

- libzmqpp-dev should probably depend on libzmq3-dev (not libzmq5-dev). The 3 version is a replacement for the deprecated 5 version, it seems. Plus that would make the Build-Depends and the Depends consistent. Not a blocker, just saying.

- This isn't in Debian, which puts all the maintenance burden on the above team. Is there a reason they don't have it?

- There's a patch ("mkdir_before_install.diff") that's not being used. Is that obsolete?

[Launchpad Janitor (janitor)]

[Expired for zmqpp (Ubuntu) because there has been no activity for 60 days.]