Magical statuses not so magical - possible for staff to edit items into or out of magical statuses

[Michele Morgan]

The "magical statuses", which currently include:

1 - Checked out
3 - Lost
6 - In transit
8 - On holds shelf
16 - Long Overdue
18 - Canceled Transit

Should be disabled in the copy editor. It should not be possible for a staff member editing an item to put the item into, or take the item out of one of these statuses.

In certain circumstances this can be foiled. Using "Checked out" as an example, a copy can be put into any magical status as follows:

- xul Copy editor:

1. Choose to "Edit Item Attributes" on an Available copy.
2. Click the Status field to edit
3. Type "c" until "Checked out" appears in the Status field.
4. Click "Apply"
5. Click "Modify Copies"

- xul Unified Editor

1. Set the library setting "Unified Volume/Item Creator/Editor" to True. Close client and relaunch.
2. Choose to "Edit Items/Volumes per Bib" on an Available copy.
3. Click the Status field to edit
4. Type "c" until "Checked out" appears in the Status field.
5. Click "Apply"
6. Click "Re-barcode / Update Items"

- Web client copy editor:

1. Choose to "Edit Items" on an Available copy.
2. Status field is fully editable. Click to open the dropdown
3. Click "Checked out"
4. Click "Save & Exit"

A copy can be taken out of a magical status as follows:

- xul Copy Editor - not possible to take an item out of a magical status.

- xul Unified Editor

1. Set the library setting "Unified Volume/Item Creator/Editor" to True. Close client and relaunch.
2. Choose to "Edit Items/Volumes per Bib" on an Checked out copy.
3. Click the Status field, which is fully editable.
4. Select "Available".
5. Click "Apply"
6. Click "Re-barcode / Update Items"

- Web Client Copy Editor:

1. Choose to "Edit Items" on an Checked out copy.
2. Status field is fully editable. Click to open the dropdown
3. Click "Available"
4. Click "Save & Exit"

[Andrea Neiman (aneiman)]

Confirmed 2.12.1, both XUL and web client as Michele describes in all cases.

[Chris Sharp (chrissharp123)]

Adding a link here to a related bug I opened almost simultaneously: https://bugs.launchpad.net/evergreen/+bug/1616170

[Jason Etheridge (phasefx)]

For now we're consolidating some webstaff bug fixes into collab/phasefx/webstaff-bugs

This particular bug should be fixed with
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=fb2d29c18b5d5630fe299fdbd12b7885a0b9170c

[Jason Etheridge (phasefx)]

hrmm, we may want to move

createSimpleUpdateWatcher('status',$scope.magic_status_list);

into the .then() for magic_status_list; not sure if there might be a race condition there (particularly if get_magic_statuses ever truly becomes async in the future)

[Jason Etheridge (phasefx)]

pushed an extra commit for what is indeed a race condition:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=e695a087864b07dfb3d2ff162e55ff570c18758d

[Andrea Neiman (aneiman)]

I have tested this code and consent to signing off on it with my name, Andrea Neiman and my email address, <email address hidden>

[Jason Etheridge (phasefx)]

Just a note, I only tackled the web client here. I poked at the XUL but it seemed too thorny.

[Andrea Neiman (aneiman)]

Since Jason's fix only addresses the webby bits, I've copied the XUL parts into a new ticket -- see bug 1695921 for the XUL version of this.

[Jason Etheridge (phasefx)]

I've force-pushed a new branch with a squashed commit:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=56a223a8a9b8a43ed0d00ca219b86b5f155e0d6c

[Galen Charlton (gmc)]

Pushed to master and rel_2_12. Thanks, Jason and Andrea!

[Galen Charlton (gmc)]

Also note bug 1698838