update-master-node.sh doesn't handle errors in deploy.sh

Bug #1616393 reported by Dmitry Burmistrov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Dmitry Burmistrov

Bug Description

Detailed bug description:
 "update-master-node.sh" script (https://github.com/openstack/fuel-library/blob/stable/mitaka/files/updates/update-master-node.sh) for MU mechanism for 9.X is not handling errors in "deploy.sh" script (https://github.com/openstack/fuel-library/blob/stable/mitaka/files/updates/update-master-node.sh#L16 - bash -x /etc/puppet/modules/fuel/examples/deploy.sh).
 As "set -e" is not set in "update-master-node.sh" script execution will ignore errors and continue. But "deploy.sh" script will fail in some cases (and do not apply other modulars) - https://github.com/openstack/fuel-library/blob/stable/mitaka/deployment/puppet/fuel/examples/deploy.sh#L47
 This will cause service restarts without proper configuration and user may not notice problem.
 9.0/9.1 releases
Description of the environment:
 Operation system: Ubuntu 14.04

Changed in fuel:
milestone: none → 9.1
assignee: nobody → Fuel Sustaining (fuel-sustaining-team)
tags: added: area-library
Changed in fuel:
status: New → Confirmed
importance: Undecided → High
Changed in fuel:
assignee: Fuel Sustaining (fuel-sustaining-team) → MOS Puppet Team (mos-puppet)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/360443

Changed in fuel:
assignee: MOS Puppet Team (mos-puppet) → Dmitry Burmistrov (dmburmistrov)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (stable/mitaka)

Reviewed: https://review.openstack.org/360443
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=b6697d87dfef73fa96aa16f02eac140d85f44b02
Submitter: Jenkins
Branch: stable/mitaka

commit b6697d87dfef73fa96aa16f02eac140d85f44b02
Author: dmburmistrov <email address hidden>
Date: Thu Aug 25 13:51:14 2016 +0300

    Fix MU update master node script

    Key moments:
    * fail "update-master-node.sh" execution on any error
    * reload systemd units after package upgrade
    * print current update "stage"
    * small refactoring (comments, quotes, etc)

    Closes-bug: #1616472
    Closes-bug: #1616393

    Change-Id: I105c16e313a47908bd90a51f6557498735aa8a42

tags: added: in-stable-mitaka
Changed in fuel:
status: Confirmed → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/358682
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=66229fdf424971cf20f95e34d4873f92da38387b
Submitter: Jenkins
Branch: master

commit 66229fdf424971cf20f95e34d4873f92da38387b
Author: Oleksiy Molchanov <email address hidden>
Date: Fri Jul 22 19:34:50 2016 +0300

    Add update-master-node script

    This script updates master node in fuel 9.x releases.
    It upgrades system packages, runs fuel/examples/deploy.sh
    as for boostrap admin node process (puppet tasks run),
    then restarts all important master node services.
    Logging for this script is also added.

    Closes-bug: #1605602

    Related-bug: #1616472
    Related-bug: #1616393

    Change-Id: Ic4ef722b861d260c3679dca9c74f6cc62052c376

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.