All Table Templates should support template overrides

Bug #1616222 reported by Diana Whitten
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Ryan Peters

Bug Description

Only some of the table templates are overridable through the meta DataTableOptions class. They would ALL be overrideable.

        self.template = getattr(options,
                                'template',
                                'horizon/common/_data_table.html')

The other templates, listed below, should also use the 'getattr' option.

        self.row_actions_dropdown_template = ('horizon/common/_data_table_'
                                              'row_actions_dropdown.html')
        self.row_actions_row_template = ('horizon/common/_data_table_'
                                         'row_actions_row.html')
        self.table_actions_template = \
            'horizon/common/_data_table_table_actions.html'

Tags: branding
Changed in horizon:
assignee: nobody → Ryan Peters (rjpeter2)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/359437

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/359437
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a988f3c457fca8cd990eec507638cf0dcc0c5011
Submitter: Jenkins
Branch: master

commit a988f3c457fca8cd990eec507638cf0dcc0c5011
Author: Ryan Peters <email address hidden>
Date: Tue Aug 23 16:27:26 2016 -0500

    All Table Templates should support template overrides

    Overrides were not possible on some templates due to
    not reading from the "options" array while assigning
    values in the DataTableOptions class.

    Change-Id: Ia0905cbf772445c39006d10a5a040b5244587914
    Closes-bug: #1616222

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 10.0.0.0rc1

This issue was fixed in the openstack/horizon 10.0.0.0rc1 release candidate.

Changed in horizon:
milestone: next → ocata-1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.