Plan Deletion Doesn't Use a Bulk Delete

[Ryan Brady]

See the comments on Plan Deletion Action patch[1] in tripleo-common.

The python-swiftclient project is used in tripleo-common when interacting with swift. The swiftclient library has no way to perform a deletion on a container that contains objects without iterating over the objects to delete them first.

Python-swiftclient doesn't provide access to a headers arg for us to inject the header. While there seems to be another document[2] that states we can use a querystring param with a POST request, the delete_container method does not provide a means to change the HTTP request method type.

Once swiftclient has been patched to allow access to headers for delete_container or provide another means to bulk delete a container, this code in tripleo-common should be updated.

[1]https://review.openstack.org/#/c/299937/15/tripleo_common/actions/plan.py@166
[2] http://docs.openstack.org/developer/swift/middleware.html#bulk-delete

[Ryan Brady (rbrady)]

From the reference [2] above, the bulk delete will not work in our case (container full of objects) as the container must be empty.

"or for a container (which must be empty at time of delete)"

[Thiago da Silva (thiagodasilva)]

@Ryan, with bulk-delete you should be able to delete both objects and container[0], no?
[0] - https://docs.openstack.org/swift/latest/middleware.html#bulk-delete

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/553616

[Carlos Camacho (ccamacho)]

@Dan, do you have planned to backport this fi to stable/queens?

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553616
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=f6891826c9ccaaca0614239d1f162a3f66a43162
Submitter: Zuul
Branch: master

commit f6891826c9ccaaca0614239d1f162a3f66a43162
Author: Dan Prince <email address hidden>
Date: Thu Mar 15 17:31:51 2018 -0400

    Use swift bulk-delete when deleting a plan

    Deleting swift containers (plans) with large numbers of files can
    take longer than we'd like.

    This patch uses the SwiftService API which contains an implementation
    of bulk delete used by the swift CLI which speeds up delete operations.

    Change-Id: I8362a7986e2e4ff0aecaf867faf47c24b658d15b
    Closes-bug: #1615825

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 10.0.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/tripleo-common/+/855099

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/train
Review: https://review.opendev.org/c/openstack/tripleo-common/+/855099
Reason: Train is about to transition to End of Life. Open patches needs to be abandoned before branch deletion.