os-vif log messages corrupt and pollute test output

Bug #1615676 reported by Jay Pipes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Sean Dague
os-vif
In Progress
Low
Sean Dague

Bug Description

When running unit tests with tox, os-vif logging pollutes the output of the testr runner and on multi-core machines, nearly always corrupts the output stream like so:

http://paste.openstack.org/show/562213/

os-vif logging setup should be examined to ensure it is being processed like all other modules that behave properly with testr.

Changed in nova:
assignee: nobody → Pushkar Umaranikar (pushkar-umaranikar)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-vif (master)

Fix proposed to branch: master
Review: https://review.openstack.org/370908

Changed in os-vif:
assignee: nobody → Pushkar Umaranikar (pushkar-umaranikar)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/371785

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on os-vif (master)

Change abandoned by Pushkar Umaranikar (<email address hidden>) on branch: master
Review: https://review.openstack.org/370908

Changed in os-vif:
assignee: Pushkar Umaranikar (pushkar-umaranikar) → Sean Dague (sdague)
Revision history for this message
Matt Riedemann (mriedem) wrote :
Changed in nova:
importance: Wishlist → Low
Changed in os-vif:
importance: Undecided → Low
Changed in nova:
assignee: Pushkar Umaranikar (pushkar-umaranikar) → Sean Dague (sdague)
importance: Low → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/374233
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=735f710ae0c0e0037970796beacd3527e2a8ca8a
Submitter: Jenkins
Branch: master

commit 735f710ae0c0e0037970796beacd3527e2a8ca8a
Author: Sean Dague <email address hidden>
Date: Wed Sep 21 11:11:21 2016 -0400

    move os_vif.initialize() to nova-compute start

    os_vif.initialize() was previously executed during module load. This
    means it was entirely possible that it was run before things like
    logging were actually set up in the expected way. Move this back into
    execution time instead of load time to ensure that logging is actually
    setup.

    Changes need to be made to tests which make assumptions about os_vif
    objects to manually initialize os_vif when it will be used. os_vif
    objects can't be created until it is initialized, so some delayed
    object creation is also done in test_vif.py.

    Closes-Bug: #1615676

    Change-Id: I89fe5c5b3d762f3a3238b587685df85d15ee56c4

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Pushkar Umaranikar (<email address hidden>) on branch: master
Review: https://review.openstack.org/371785
Reason: The issue is addressed in https://review.openstack.org/#/c/374233/. Hence, abandoning this change.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 15.0.0.0b1

This issue was fixed in the openstack/nova 15.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.