When a user show a angular image panel, the request to get images is called twice

Bug #1615573 reported by Kenji Ishii
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Richard Jones

Bug Description

Reproduce
1. logged in horizon
2. display Project -> Compute -> Images

In this case, horizon will request images but at the moment the request is called twice.
As far as I confirmed, ResourceTableController is called twice. As a result, onResourceTypeNameChange also called twice.
A behavior from a end user's aspect is no problem but we should reduce unnecessary request.

Tags: angularjs
Changed in horizon:
status: New → Confirmed
importance: Undecided → High
milestone: none → newton-3
tags: added: angularjs
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/359033

Changed in horizon:
assignee: nobody → Kenji Ishii (ken-ishii)
status: Confirmed → In Progress
Changed in horizon:
milestone: newton-3 → newton-rc1
Changed in horizon:
assignee: Kenji Ishii (ken-ishii) → Richard Jones (r1chardj0n3s)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/359033
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f91d38bd6e73777149d68b0c5a2ab5c5c2e93a92
Submitter: Jenkins
Branch: master

commit f91d38bd6e73777149d68b0c5a2ab5c5c2e93a92
Author: Kenji Ishii <email address hidden>
Date: Tue Aug 23 17:26:10 2016 +0900

    Fix unnecessary requests in angular image panel

    When displaying angular image panel, the request to get images is
    called twice. This is caused by the setting of routeProvider.
    This patch will fix it.

    Change-Id: I37db691e846d3b80fa21794922e1998cc23243e3
    Closes-Bug: #1615573

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 10.0.0.0rc1

This issue was fixed in the openstack/horizon 10.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.