NetApp cDOT doesn't report replication_enabled as a pool level capability

[Goutham Pacha Ravi]

Steps to reproduce:

* Set up cheesecake replication with cDOT
* Create volume type with replication_enabled extra spec

$ cinder extra-specs-list
+--------------------------------------+--------------------+---------------------------------------------------------------------------+
| ID | Name | extra_specs |
+--------------------------------------+--------------------+---------------------------------------------------------------------------+
| a4dbd246-2d94-45ba-bf57-88379e78fc8e | cheesecake-volumes | {'replication_enabled': '<is> True', 'volume_backend_name': 'cmodeiSCSI'} |
+--------------------------------------+--------------------+---------------------------------------------------------------------------+

* Create a volume with that extra-spec:

$ cinder create 2 --name my_vol_1 --volume-type cheesecake-volumes

Scheduler will set the volume to error.

Sample scheduler stats from cDOT:

2016-08-21 20:48:35.422 DEBUG cinder.scheduler.host_manager [req-5801c249-a19d-4981-8fe8-ec38a55bf102 None None] Received volume service update from openstack9@cmodeiSCSI: {u'filter_function': u'capabilities.utilization < 70', u'replication_enabled': True, u'goodness_function': u'100 - capabilities.utilization', u'replication_count': 1, u'replication_type': u'async', u'volume_backend_name': u'cmodeiSCSI', u'driver_version': u'1.0.0', u'sparse_copy_volume': True, u'replication_targets': [u'target_gouthamr_02'], u'pools': [{u'thick_provisioning_support': True, u'netapp_aggregate': u'aggr1', u'total_capacity_gb': 15.0, u'filter_function': u'capabilities.utilization < 70', u'netapp_aggregate_used_percent': 12, u'utilization': 6.57, u'free_capacity_gb': 14.99, u'netapp_compression': u'false', u'pool_name': u'cheesecake_02', u'goodness_function': u'100 - capabilities.utilization', u'provisioned_capacity_gb': 0.01, u'allocated_capacity_gb': 0, u'thin_provisioning_support': False, u'reserved_percentage': 0, u'netapp_raid_type': u'raid_dp', u'netapp_disk_type': [u'SATA'], u'QoS_support': True, u'netapp_hybrid_aggregate': u'false', u'netapp_mirrored': u'false', u'netapp_dedup': u'false', u'netapp_thin_provisioned': u'false', u'max_over_subscription_ratio': 20.0, u'consistencygroup_support': True}, {u'thick_provisioning_support': False, u'netapp_aggregate': u'aggr2', u'total_capacity_gb': 20.0, u'filter_function': u'capabilities.utilization < 70', u'netapp_aggregate_used_percent': 24, u'utilization': 12.19, u'free_capacity_gb': 17.99, u'netapp_compression': u'false', u'pool_name': u'cheesecake_01', u'goodness_function': u'100 - capabilities.utilization', u'provisioned_capacity_gb': 2.01, u'allocated_capacity_gb': 2, u'thin_provisioning_support': True, u'reserved_percentage': 0, u'netapp_raid_type': u'raid_dp', u'netapp_disk_type': [u'SATA'], u'QoS_support': True, u'netapp_hybrid_aggregate': u'false', u'netapp_mirrored': u'false', u'netapp_dedup': u'true', u'netapp_thin_provisioned': u'true', u'max_over_subscription_ratio': 20.0, u'consistencygroup_support': True}], u'vendor_name': u'NetApp', u'storage_protocol': u'iSCSI'}

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/366939

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/366939
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=623990df64092fe72a6473ac89fff1ba0d3aaec7
Submitter: Jenkins
Branch: master

commit 623990df64092fe72a6473ac89fff1ba0d3aaec7
Author: Goutham Pacha Ravi <email address hidden>
Date: Fri Aug 26 21:47:44 2016 -0400

    NetApp cDOT: Fix reporting of replication capabilities

    Host level replication capability was added to the NetApp
    cDOT Block and File drivers through
    I87b92e76d0d5022e9be610b9e237b89417309c05.
    However, the replication capability was not being reported
    at the pool level.

    Add the field at pool level allowing for compatibility with
    volume types that may include the `replication_enabled`
    extra-spec.

    Change-Id: Ic735a527c609166884668c84c589da521769500b
    Closes-Bug: #1615451

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 9.0.0.0rc1 release candidate.