Comment regarding available_themes parameter needs clarifying

Bug #1615046 reported by Nick Jones
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-horizon
Fix Released
Medium
Nick Jones

Bug Description

The existing comment regarding the available_themes parameter isn't strictly true in that the datatype is actually an array of hashes, not a hash. This can lead to some confusion especially when specifying data in YAML via Hiera.

The code could be refactored to take a hash keyed off a theme name, but the existing code in the template works as long as the source data is in the right format. The quickest win therefore is to update the comment.

Nick Jones (yankcrime)
Changed in puppet-horizon:
assignee: nobody → Nick Jones (yankcrime)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/358013

Changed in puppet-horizon:
status: New → In Progress
Changed in puppet-horizon:
importance: Undecided → Medium
milestone: none → 9.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (master)

Reviewed: https://review.openstack.org/358013
Committed: https://git.openstack.org/cgit/openstack/puppet-horizon/commit/?id=1f209355da86e6b696445ba9e0bdedcf58de9d13
Submitter: Jenkins
Branch: master

commit 1f209355da86e6b696445ba9e0bdedcf58de9d13
Author: Nick Jones <email address hidden>
Date: Fri Aug 19 17:50:31 2016 +0100

    Update comment regarding the available_themes parameter

    This commit clarifies the available_themes parameter and its usage so as to save
    any confusion, especially when using Hiera.

    Change-Id: I3bba9ab71eb94bacf262adb71822f7261c7e716c
    Closes-bug: 1615046

Changed in puppet-horizon:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/puppet-horizon 9.2.0

This issue was fixed in the openstack/puppet-horizon 9.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.