BackupHelper tasks will never get marked as cancelled
Bug #1614695 reported by
Charles Kerr
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Keeper |
In Progress
|
Medium
|
Unassigned |
Bug Description
In this block:
> if (n_uploaded_ == q_ptr->
> {
> q_ptr->
> }
> else if (read_error_ || write_error_ || n_uploaded_ != q_ptr->
> {
> q_ptr->
> }
> else if (cancelled_)
> {
> q_ptr->
> }
We'll never reach the third else because any value of n_uploaded will either be
"== q_ptr->
"!= q_ptr->
As written this block wrongly behaves as:
q_ptr-
Related branches
lp:~charlesk/keeper/lp-1614764-fix-excess-signal-subscriptions
Merged
into
lp:keeper/devel
- Xavi Garcia (community): Approve
- unity-api-1-bot: Needs Fixing (continuous-integration)
-
Diff: 277 lines (+91/-64)4 files modifiedsrc/helper/backup-helper.cpp (+16/-20)
src/service/keeper.cpp (+66/-25)
src/storage-framework/storage_framework_client.cpp (+5/-15)
tests/integration/helpers/helpers-test-failure.cpp (+4/-4)
summary: |
- BackupHelper tasks will never get marked as CANCELLED + BackupHelper tasks will never get marked as cancelled |
Changed in keeper: | |
status: | New → In Progress |
importance: | Undecided → Medium |
To post a comment you must log in.