Fail to retype lvm volume to scaleio

[Feodor Tersin]

The retype operation stops on volume renaming stage.

The reason is that volume.provider_id is None, and for rename operation ScaleIO server returns status_code 400 (bad request), but error_code 0. This case is not catched in ScaleIODriver._rename_volume method, and therefore the retype operation is not being completed.

In other words the solution of https://bugs.launchpad.net/cinder/+bug/1604703 needs to be improved.

ps. I tried 'asdf' as a volume id, and ScaleIO returned 400 as well. Because that i think that ScaleIO can return 400 for non empty provider_id of some drivers. So that a fix of this bug must check status_code for 400 error, but not just to test provider_id and return if None.

[Matan Sabag (matan-sabag)]

Can you add the logs please?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/368357

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/368357
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=2089e4e5e57ae32a26cbd06b35a57a186b8ee7b4
Submitter: Jenkins
Branch: master

commit 2089e4e5e57ae32a26cbd06b35a57a186b8ee7b4
Author: Matan Sabag <email address hidden>
Date: Sat Sep 10 14:00:29 2016 -0700

    Fixed illegal syntax error code in ScaleIO rename volume

    When retype calls _rename_volume() method with an
    illegal syntax it fails with a different error code 0.

    Closes-Bug: #1614598
    Change-Id: I1170e291aa082bd920e3d24169faf7d93d07a4b7

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 9.0.0.0rc1 release candidate.