neutron: instance.info_cache isn't refreshed after deleting associated floating IP

[Matt Riedemann]

Shown in a tempest test here:

http://logs.openstack.org/95/356095/2/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/8d3cbb2/console.html#_2016-08-18_03_18_38_290951

You can see from this patch that we refresh the instance's network info_cache (server.addresses) when deleting a floating IP associated with that instance but only when using nova-network, we don't do it for neutron.

This is related to bug 1586931 and investigation that happened in https://review.openstack.org/#/c/351960/.

Basically the problem is that this method isn't decorated with the refresh_cache decorator:

https://github.com/openstack/nova/blob/d14fc79f65e04cc39a3988783344aecd84621291/nova/network/neutronv2/api.py#L1826

But notice that this is:

https://github.com/openstack/nova/blob/d14fc79f65e04cc39a3988783344aecd84621291/nova/network/neutronv2/api.py#L1845

That's the method that's called from the REST API when disassociating, but not deleting, a floating IP from a server.

[Matt Riedemann (mriedem)]

Once this is fixed in nova we can land a tempest test to continue to verify this behavior in the API.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/357494

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/357494
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=cdb9b6820dc17971bca24adfc0b56f030f0ae827
Submitter: Jenkins
Branch: master

commit cdb9b6820dc17971bca24adfc0b56f030f0ae827
Author: Michael Wurtz <email address hidden>
Date: Thu Aug 18 14:53:33 2016 -0500

    Refresh info_cache after deleting floating IP

    When deleting a floating IP associated with Neutron's info_cache we don't
    refresh the info_cache after it is deleted.
    This patch makes it so the info_cache is refreshed when an associated
    floating IP is deleted. If there is no info_cache associated with the
    floating IP then info_cache is not refreshed.

    Change-Id: I8a8ae8cdbe2d9d77e7f1ae94ebdf6e4ad46eaf00
    Closes-Bug: #1614538

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/366994
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a832e6b2a019323fdf00e30302ad5c3c809baa21
Submitter: Jenkins
Branch: stable/mitaka

commit a832e6b2a019323fdf00e30302ad5c3c809baa21
Author: Michael Wurtz <email address hidden>
Date: Thu Aug 18 14:53:33 2016 -0500

    Refresh info_cache after deleting floating IP

    When deleting a floating IP associated with Neutron's info_cache we don't
    refresh the info_cache after it is deleted.
    This patch makes it so the info_cache is refreshed when an associated
    floating IP is deleted. If there is no info_cache associated with the
    floating IP then info_cache is not refreshed.

    Change-Id: I8a8ae8cdbe2d9d77e7f1ae94ebdf6e4ad46eaf00
    Closes-Bug: #1614538
    (cherry picked from commit cdb9b6820dc17971bca24adfc0b56f030f0ae827)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/366996
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=15cfd039fe30456e9ff19cfb9572d981c6b991f6
Submitter: Jenkins
Branch: stable/liberty

commit 15cfd039fe30456e9ff19cfb9572d981c6b991f6
Author: Michael Wurtz <email address hidden>
Date: Thu Aug 18 14:53:33 2016 -0500

    Refresh info_cache after deleting floating IP

    When deleting a floating IP associated with Neutron's info_cache we don't
    refresh the info_cache after it is deleted.
    This patch makes it so the info_cache is refreshed when an associated
    floating IP is deleted. If there is no info_cache associated with the
    floating IP then info_cache is not refreshed.

    Change-Id: I8a8ae8cdbe2d9d77e7f1ae94ebdf6e4ad46eaf00
    Closes-Bug: #1614538
    (cherry picked from commit cdb9b6820dc17971bca24adfc0b56f030f0ae827)
    (cherry picked from commit a832e6b2a019323fdf00e30302ad5c3c809baa21)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 14.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 12.0.5 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 13.1.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 14.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 12.0.5 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 13.1.2 release.